[PATCH v1] gpio: mmio: fix calculation of bgpio_bits

[PATCH v1] gpio: mmio: fix calculation of bgpio_bits

[Asmaa Mnebhi]

If the "ngpios" property is specified, bgpio_bits is calculated
as the round up value of ngpio. At the moment, the only requirement
specified is that the round up value must be a multiple of 8 but
it should also be a power of 2 because we provide accessors based
on the bank size in bgpio_setup_accessors().

Signed-off-by: Asmaa Mnebhi <asmaa@nvidia.com>
---
 drivers/gpio/gpio-mmio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-mmio.c b/drivers/gpio/gpio-mmio.c
index b52a3dd511ca..74fdf0d87b2c 100644
--- a/drivers/gpio/gpio-mmio.c
+++ b/drivers/gpio/gpio-mmio.c
@@ -623,7 +623,7 @@ int bgpio_init(struct gpio_chip *gc, struct device *dev,
 	if (ret)
 		gc->ngpio = gc->bgpio_bits;
 	else
-		gc->bgpio_bits = round_up(gc->ngpio, 8);
+		gc->bgpio_bits = roundup_pow_of_two(round_up(gc->ngpio, 8));
 
 	ret = bgpio_setup_io(gc, dat, set, clr, flags);
 	if (ret)
-- 
2.30.1

Re: [PATCH v1] gpio: mmio: fix calculation of bgpio_bits

[Andy Shevchenko]

On Thu, Mar 23, 2023 at 10:57 PM Asmaa Mnebhi <asmaa@nvidia.com> wrote:
>
> If the "ngpios" property is specified, bgpio_bits is calculated
> as the round up value of ngpio. At the moment, the only requirement
> specified is that the round up value must be a multiple of 8 but
> it should also be a power of 2 because we provide accessors based
> on the bank size in bgpio_setup_accessors().

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Asmaa Mnebhi <asmaa@nvidia.com>
> ---
>  drivers/gpio/gpio-mmio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-mmio.c b/drivers/gpio/gpio-mmio.c
> index b52a3dd511ca..74fdf0d87b2c 100644
> --- a/drivers/gpio/gpio-mmio.c
> +++ b/drivers/gpio/gpio-mmio.c
> @@ -623,7 +623,7 @@ int bgpio_init(struct gpio_chip *gc, struct device *dev,
>         if (ret)
>                 gc->ngpio = gc->bgpio_bits;
>         else
> -               gc->bgpio_bits = round_up(gc->ngpio, 8);
> +               gc->bgpio_bits = roundup_pow_of_two(round_up(gc->ngpio, 8));
>
>         ret = bgpio_setup_io(gc, dat, set, clr, flags);
>         if (ret)
> --
> 2.30.1
>


-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1] gpio: mmio: fix calculation of bgpio_bits

[Andy Shevchenko]

On Fri, Mar 24, 2023 at 2:07 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Thu, Mar 23, 2023 at 10:57 PM Asmaa Mnebhi <asmaa@nvidia.com> wrote:
> >
> > If the "ngpios" property is specified, bgpio_bits is calculated
> > as the round up value of ngpio. At the moment, the only requirement
> > specified is that the round up value must be a multiple of 8 but
> > it should also be a power of 2 because we provide accessors based
> > on the bank size in bgpio_setup_accessors().
>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

Btw, I do not see the initial patch in Bart's tree. I suppose you may
simply send a v5 of the original one with this fix applied inplace.

-- 
With Best Regards,
Andy Shevchenko

RE: [PATCH v1] gpio: mmio: fix calculation of bgpio_bits

[Asmaa Mnebhi]

> > >
> > > If the "ngpios" property is specified, bgpio_bits is calculated as
> > > the round up value of ngpio. At the moment, the only requirement
> > > specified is that the round up value must be a multiple of 8 but it
> > > should also be a power of 2 because we provide accessors based on
> > > the bank size in bgpio_setup_accessors().
> >
> > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> 
> Btw, I do not see the initial patch in Bart's tree. I suppose you may simply
> send a v5 of the original one with this fix applied inplace.
> 
Yes I was not able to find it on any branch yet so I just sent this patch based the other one.

RE: [PATCH v1] gpio: mmio: fix calculation of bgpio_bits

[Asmaa Mnebhi]

> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> 
Hi Bart,

Could you please add this patch to the tree?

Thanks.
Asmaa

Re: [PATCH v1] gpio: mmio: fix calculation of bgpio_bits

[Bartosz Golaszewski]

On Mon, Jul 10, 2023 at 7:26 PM Asmaa Mnebhi <asmaa@nvidia.com> wrote:
>
> > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> >
> Hi Bart,
>
> Could you please add this patch to the tree?
>
> Thanks.
> Asmaa

You still haven't sent it to my address and it's not rebased on top of v6.5-rc1.

Bart

Re: [PATCH v1] gpio: mmio: fix calculation of bgpio_bits

[Linus Walleij]

On Thu, Mar 23, 2023 at 9:57 PM Asmaa Mnebhi <asmaa@nvidia.com> wrote:

> If the "ngpios" property is specified, bgpio_bits is calculated
> as the round up value of ngpio. At the moment, the only requirement
> specified is that the round up value must be a multiple of 8 but
> it should also be a power of 2 because we provide accessors based
> on the bank size in bgpio_setup_accessors().
>
> Signed-off-by: Asmaa Mnebhi <asmaa@nvidia.com>

Neat fixup,
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij