mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] alpha: kernel: module: Adding branch statements after allocating memory for kmalloc
@ 2023-03-25 19:25 Li kunyu
  0 siblings, 0 replies; only message in thread
From: Li kunyu @ 2023-03-25 19:25 UTC (permalink / raw)
  To: richard.henderson, ink, mattst88, aurxenon; +Cc: linux-kernel, Li kunyu

After looking at the process_reloc_for_got function and where it is
called, I decided to use a branch statement to increase the robustness
of the pointer g.

If pointer g allocation fails, when 'chains [i]. next' is executed, it
can avoid crashes caused by wild pointers.

Signed-off-by: Li kunyu <kunyu@nfschina.com>
---
 arch/alpha/kernel/module.c | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/arch/alpha/kernel/module.c b/arch/alpha/kernel/module.c
index cbefa5a77384..8c97f10347a7 100644
--- a/arch/alpha/kernel/module.c
+++ b/arch/alpha/kernel/module.c
@@ -47,11 +47,15 @@ process_reloc_for_got(Elf64_Rela *rela,
 		}
 
 	g = kmalloc (sizeof (*g), GFP_KERNEL);
-	g->next = chains[r_sym].next;
-	g->r_addend = r_addend;
-	g->got_offset = *poffset;
-	*poffset += 8;
-	chains[r_sym].next = g;
+	if (g) {
+		g->next = chains[r_sym].next;
+		g->r_addend = r_addend;
+		g->got_offset = *poffset;
+		*poffset += 8;
+		chains[r_sym].next = g;
+	}
+	else
+		chains[r_sym].next = NULL;
 
  found_entry:
 	/* Trick: most of the ELF64_R_TYPE field is unused.  There are
-- 
2.18.2


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-03-24  2:54 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-25 19:25 [PATCH] alpha: kernel: module: Adding branch statements after allocating memory for kmalloc Li kunyu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®