* [PATCH v2] arm64: dts: rockchip: Remove non-existing pwm-delay-us property
@ 2023-03-30 23:19 Javier Martinez Canillas
2023-03-31 0:46 ` Heiko Stuebner
0 siblings, 1 reply; 2+ messages in thread
From: Javier Martinez Canillas @ 2023-03-30 23:19 UTC (permalink / raw)
To: linux-kernel
Cc: Javier Martinez Canillas, Brian Norris, Daniel Lezcano,
Douglas Anderson, Enric Balletbo i Serra, Heiko Stuebner,
Judy Hsiao, Krzysztof Kozlowski, Lin Huang, Rob Herring,
devicetree, linux-arm-kernel, linux-rockchip, zain wang
There is neither a driver that parses this nor a DT binding schema that
documents it, so let's remove from the DTS files that make use of this.
The properties that exist are post-pwm-on-delay-ms and pwm-off-delay-ms,
defined in the pwm-backlight DT binding. If the delays are really needed
then those properties should be used instead.
Brian Norris mentioned though that looking at the first downstream usage
of the pwm-delay-us property for RK3399 Gru systems in ChromiumOS tree,
he couldn't find a spec reference that said that this was really needed.
So perhaps it was unnecessary added and a simple removal would be enough.
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Brian Norris <briannorris@chromium.org>
---
Changes in v2:
- Update commit message with the information provided by Brian Norries.
- Add Reviewed-by tag from Brian Norries.
arch/arm64/boot/dts/rockchip/rk3368-evb.dtsi | 1 -
arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi | 1 -
arch/arm64/boot/dts/rockchip/rk3399-gru-scarlet.dtsi | 1 -
3 files changed, 3 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3368-evb.dtsi b/arch/arm64/boot/dts/rockchip/rk3368-evb.dtsi
index 083452c67711..e47d1398aeca 100644
--- a/arch/arm64/boot/dts/rockchip/rk3368-evb.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3368-evb.dtsi
@@ -61,7 +61,6 @@ backlight: backlight {
pinctrl-names = "default";
pinctrl-0 = <&bl_en>;
pwms = <&pwm0 0 1000000 PWM_POLARITY_INVERTED>;
- pwm-delay-us = <10000>;
};
emmc_pwrseq: emmc-pwrseq {
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi
index ee6095baba4d..5c1929d41cc0 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi
@@ -198,7 +198,6 @@ backlight: backlight {
power-supply = <&pp3300_disp>;
pinctrl-names = "default";
pinctrl-0 = <&bl_en>;
- pwm-delay-us = <10000>;
};
gpio_keys: gpio-keys {
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-scarlet.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-gru-scarlet.dtsi
index a47d9f758611..c5e7de60c121 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-gru-scarlet.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-scarlet.dtsi
@@ -167,7 +167,6 @@ backlight: backlight {
pinctrl-names = "default";
pinctrl-0 = <&bl_en>;
pwms = <&pwm1 0 1000000 0>;
- pwm-delay-us = <10000>;
};
dmic: dmic {
base-commit: b2bc47e9b2011a183f9d3d3454a294a938082fb9
--
2.40.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] arm64: dts: rockchip: Remove non-existing pwm-delay-us property
2023-03-30 23:19 [PATCH v2] arm64: dts: rockchip: Remove non-existing pwm-delay-us property Javier Martinez Canillas
@ 2023-03-31 0:46 ` Heiko Stuebner
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2023-03-31 0:46 UTC (permalink / raw)
To: linux-kernel, Javier Martinez Canillas
Cc: Heiko Stuebner, Judy Hsiao, zain wang, linux-rockchip, Lin Huang,
Brian Norris, linux-arm-kernel, Daniel Lezcano, Douglas Anderson,
devicetree, Rob Herring, Krzysztof Kozlowski,
Enric Balletbo i Serra
On Fri, 31 Mar 2023 01:19:23 +0200, Javier Martinez Canillas wrote:
> There is neither a driver that parses this nor a DT binding schema that
> documents it, so let's remove from the DTS files that make use of this.
>
> The properties that exist are post-pwm-on-delay-ms and pwm-off-delay-ms,
> defined in the pwm-backlight DT binding. If the delays are really needed
> then those properties should be used instead.
>
> [...]
Applied, thanks!
[1/1] arm64: dts: rockchip: Remove non-existing pwm-delay-us property
commit: 3adf89324a2b2a9dbc2c12d8895021e7e34e3346
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-31 0:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-30 23:19 [PATCH v2] arm64: dts: rockchip: Remove non-existing pwm-delay-us property Javier Martinez Canillas
2023-03-31 0:46 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®