From: "Michal Koutný" <mkoutny@suse.com>
To: Waiman Long <longman@redhat.com>
Cc: Tejun Heo <tj@kernel.org>, Zefan Li <lizefan.x@bytedance.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Christian Brauner <brauner@kernel.org>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
Juri Lelli <juri.lelli@redhat.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
gscrivan@redhat.com
Subject: Re: [PATCH 3/3] cgroup/cpuset: Allow only one active attach operation per cpuset
Date: Tue, 4 Apr 2023 11:07:37 +0200 [thread overview]
Message-ID: <20230404090737.3g3uxga52bojgdu5@blackpad> (raw)
In-Reply-To: <24b67530-62ce-4f9c-7b74-d41d2ccc710e@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 763 bytes --]
Hi.
On Mon, Apr 03, 2023 at 01:41:33PM -0400, Waiman Long <longman@redhat.com> wrote:
> This patch is actually not related to the CLONE_INTO_GROUP problem in patch
> 1. It is a generic problem when multiple users are moving threads into
> cgroup.threads of the same or different cpusets simultaneously.
I meant this:
__cgroup_procs_write
cgroup_kn_lock_live
mutex_lock(&cgroup_mutex)
and (more succintly)
cgroup_update_dfl_csses
lockdep_assert_held(&cgroup_mutex)
Even the threaded migrations should be synchronized here.
Can you please explain in more detail what's the problematic case?
> I don't believe this patch has a dependency on patch 1.
(I meant the opposite, patch 1 would depend in this 3/3. But maybe this
one isn't need.)
Michal
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-04-04 9:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 14:50 [PATCH 0/3] cgroup/cpuset: Fix CLONE_INTO_CGROUP problem & other issues Waiman Long
2023-03-31 14:50 ` [PATCH 1/3] cgroup/cpuset: Make cpuset_fork() handle CLONE_INTO_CGROUP properly Waiman Long
2023-04-03 16:55 ` Michal Koutný
2023-04-03 17:18 ` Waiman Long
2023-04-03 17:29 ` Waiman Long
2023-04-04 9:19 ` Michal Koutný
2023-04-04 13:52 ` Waiman Long
2023-04-04 17:26 ` Waiman Long
2023-04-06 2:51 ` kernel test robot
2023-04-06 12:17 ` Waiman Long
2023-04-06 9:45 ` Christian Brauner
2023-04-06 14:08 ` Waiman Long
2023-03-31 14:50 ` [PATCH 2/3] cgroup/cpuset: Make cpuset_attach_task() skip subpartitions CPUs for top_cpuset Waiman Long
2023-04-03 16:35 ` Michal Koutný
2023-03-31 14:50 ` [PATCH 3/3] cgroup/cpuset: Allow only one active attach operation per cpuset Waiman Long
2023-04-03 16:47 ` Michal Koutný
2023-04-03 17:41 ` Waiman Long
2023-04-04 9:07 ` Michal Koutný [this message]
2023-04-04 14:12 ` Waiman Long
2023-04-06 9:44 ` Christian Brauner
2023-04-07 15:30 ` Waiman Long
2023-04-09 11:46 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230404090737.3g3uxga52bojgdu5@blackpad \
--to=mkoutny@suse.com \
--cc=brauner@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=dietmar.eggemann@arm.com \
--cc=gscrivan@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=longman@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®