* [PATCH] nvmem: imx-ocotp: set varaiable imx_ocotp_layout storage-class-specifier to static
@ 2023-04-04 18:31 Tom Rix
2023-05-09 9:18 ` Srinivas Kandagatla
0 siblings, 1 reply; 2+ messages in thread
From: Tom Rix @ 2023-04-04 18:31 UTC (permalink / raw)
To: srinivas.kandagatla, shawnguo, s.hauer, kernel, festevam, linux-imx
Cc: linux-arm-kernel, linux-kernel, Tom Rix
smatch reports
drivers/nvmem/imx-ocotp.c:599:21: warning: symbol
'imx_ocotp_layout' was not declared. Should it be static?
This variable is only used in one file so should be static.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/nvmem/imx-ocotp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvmem/imx-ocotp.c b/drivers/nvmem/imx-ocotp.c
index ac0edb6398f1..fcea9c04be96 100644
--- a/drivers/nvmem/imx-ocotp.c
+++ b/drivers/nvmem/imx-ocotp.c
@@ -596,7 +596,7 @@ static void imx_ocotp_fixup_cell_info(struct nvmem_device *nvmem,
cell->read_post_process = imx_ocotp_cell_pp;
}
-struct nvmem_layout imx_ocotp_layout = {
+static struct nvmem_layout imx_ocotp_layout = {
.fixup_cell_info = imx_ocotp_fixup_cell_info,
};
--
2.27.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] nvmem: imx-ocotp: set varaiable imx_ocotp_layout storage-class-specifier to static
2023-04-04 18:31 [PATCH] nvmem: imx-ocotp: set varaiable imx_ocotp_layout storage-class-specifier to static Tom Rix
@ 2023-05-09 9:18 ` Srinivas Kandagatla
0 siblings, 0 replies; 2+ messages in thread
From: Srinivas Kandagatla @ 2023-05-09 9:18 UTC (permalink / raw)
To: Tom Rix, shawnguo, s.hauer, kernel, festevam, linux-imx
Cc: linux-arm-kernel, linux-kernel
On 04/04/2023 19:31, Tom Rix wrote:
> smatch reports
> drivers/nvmem/imx-ocotp.c:599:21: warning: symbol
> 'imx_ocotp_layout' was not declared. Should it be static?
>
> This variable is only used in one file so should be static.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
Applied thanks,
--srini
> drivers/nvmem/imx-ocotp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvmem/imx-ocotp.c b/drivers/nvmem/imx-ocotp.c
> index ac0edb6398f1..fcea9c04be96 100644
> --- a/drivers/nvmem/imx-ocotp.c
> +++ b/drivers/nvmem/imx-ocotp.c
> @@ -596,7 +596,7 @@ static void imx_ocotp_fixup_cell_info(struct nvmem_device *nvmem,
> cell->read_post_process = imx_ocotp_cell_pp;
> }
>
> -struct nvmem_layout imx_ocotp_layout = {
> +static struct nvmem_layout imx_ocotp_layout = {
> .fixup_cell_info = imx_ocotp_fixup_cell_info,
> };
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-09 9:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-04 18:31 [PATCH] nvmem: imx-ocotp: set varaiable imx_ocotp_layout storage-class-specifier to static Tom Rix
2023-05-09 9:18 ` Srinivas Kandagatla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®