mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jessica Zhang <quic_jesszhan@quicinc.com>
To: Rob Clark <robdclark@gmail.com>,
	Abhinav Kumar <quic_abhinavk@quicinc.com>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Sean Paul <sean@poorly.run>, David Airlie <airlied@gmail.com>,
	Daniel Vetter <daniel@ffwll.ch>,
	Marijn Suijten <marijn.suijten@somainline.org>
Cc: Konrad Dybcio <konrad.dybcio@linaro.org>,
	<linux-arm-msm@vger.kernel.org>,
	<dri-devel@lists.freedesktop.org>,
	<freedreno@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
	Jessica Zhang <quic_jesszhan@quicinc.com>
Subject: [PATCH v2 2/4] drm/msm/dsi: Fix compressed word count calculation
Date: Fri, 5 May 2023 14:23:49 -0700	[thread overview]
Message-ID: <20230405-add-dsc-support-v2-2-1072c70e9786@quicinc.com> (raw)
In-Reply-To: <20230405-add-dsc-support-v2-0-1072c70e9786@quicinc.com>

Currently, word count is calculated using slice_count. This is incorrect
as downstream uses slice per packet, which is different from
slice_count.

Slice count represents the number of soft slices per interface, and its
value will not always match that of slice per packet. For example, it is
possible to have cases where there are multiple soft slices per interface
but the panel specifies only one slice per packet.

Thus, use the default value of one slice per packet and remove slice_count
from the word count calculation.

Changes in v2:
- "drm_panel" -> "mipi_dsi_device" in TODO comment

Fixes: bc6b6ff8135c ("drm/msm/dsi: Use DSC slice(s) packet size to compute word count")
Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com>
---
 drivers/gpu/drm/msm/dsi/dsi_host.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
index 0e5778e8091f..f6fb32e2223c 100644
--- a/drivers/gpu/drm/msm/dsi/dsi_host.c
+++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
@@ -999,7 +999,14 @@ static void dsi_timing_setup(struct msm_dsi_host *msm_host, bool is_bonded_dsi)
 		if (!msm_host->dsc)
 			wc = hdisplay * dsi_get_bpp(msm_host->format) / 8 + 1;
 		else
-			wc = msm_host->dsc->slice_chunk_size * msm_host->dsc->slice_count + 1;
+			/*
+			 * When DSC is enabled, WC = slice_chunk_size * slice_per_packet + 1.
+			 * Currently, the driver only supports default value of slice_per_packet = 1
+			 *
+			 * TODO: Expand mipi_dsi_device struct to hold slice_per_packet info
+			 *       and adjust DSC math to account for slice_per_packet.
+			 */
+			wc = msm_host->dsc->slice_chunk_size + 1;
 
 		dsi_write(msm_host, REG_DSI_CMD_MDP_STREAM0_CTRL,
 			DSI_CMD_MDP_STREAM0_CTRL_WORD_COUNT(wc) |

-- 
2.40.1


  parent reply	other threads:[~2023-05-05 21:24 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-05 21:23 [PATCH v2 0/4] Add DSC v1.2 Support for DSI Jessica Zhang
2023-05-05 21:23 ` [PATCH v2 1/4] drm/msm/dsi: Adjust pclk rate for compression Jessica Zhang
2023-05-05 21:49   ` Jessica Zhang
2023-05-08 21:56     ` Marijn Suijten
2023-05-19 19:04       ` Jessica Zhang
2023-05-19 21:20         ` Marijn Suijten
2023-05-05 21:23 ` Jessica Zhang [this message]
2023-05-05 21:23 ` [PATCH v2 3/4] drm/msm/dpu: Add DPU_INTF_DATA_COMPRESS feature flag Jessica Zhang
2023-05-07 16:00   ` Marijn Suijten
2023-05-07 19:21     ` Dmitry Baryshkov
2023-05-08 21:47       ` Marijn Suijten
2023-05-08  8:36     ` Konrad Dybcio
2023-05-08 21:53       ` Marijn Suijten
2023-05-08 21:46     ` Jessica Zhang
2023-05-08 21:50       ` Marijn Suijten
2023-05-08 23:08       ` Dmitry Baryshkov
2023-05-09  0:28         ` Abhinav Kumar
2023-05-09  0:48           ` Dmitry Baryshkov
2023-05-09  6:59         ` Marijn Suijten
2023-05-09 11:12           ` Dmitry Baryshkov
2023-05-05 21:23 ` [PATCH v2 4/4] drm/msm/dpu: Set DATA_COMPRESS for command mode Jessica Zhang
2023-05-07 16:06   ` Marijn Suijten
2023-05-08 23:17     ` Jessica Zhang
2023-05-09  0:00       ` [Freedreno] " Jessica Zhang
2023-05-09  6:49         ` Marijn Suijten
2023-05-09  6:46       ` Marijn Suijten

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230405-add-dsc-support-v2-2-1072c70e9786@quicinc.com \
    --to=quic_jesszhan@quicinc.com \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=sean@poorly.run \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®