From: "D. Starke" <daniel.starke@siemens.com>
To: linux-serial@vger.kernel.org, gregkh@linuxfoundation.org,
jirislaby@kernel.org, ilpo.jarvinen@linux.intel.com
Cc: linux-kernel@vger.kernel.org, Daniel Starke <daniel.starke@siemens.com>
Subject: [PATCH 7/9] tty: n_gsm: increase gsm_mux unsupported counted where appropriate
Date: Wed, 5 Apr 2023 07:47:28 +0200 [thread overview]
Message-ID: <20230405054730.3850-7-daniel.starke@siemens.com> (raw)
In-Reply-To: <20230405054730.3850-1-daniel.starke@siemens.com>
From: Daniel Starke <daniel.starke@siemens.com>
The structure gsm_mux contains the 'unsupported' field. However, there is
currently no place in the code which increases this counter.
Increase the 'unsupported' statistics counter in the following case:
- an unsupported frame type has been requested by the peer via parameter
negotiation
- a control frame with an unsupported but known command has been received
Signed-off-by: Daniel Starke <daniel.starke@siemens.com>
---
drivers/tty/n_gsm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index 317aa67ed169..49cb2dbfa233 100644
--- a/drivers/tty/n_gsm.c
+++ b/drivers/tty/n_gsm.c
@@ -1589,6 +1589,7 @@ static int gsm_process_negotiation(struct gsm_mux *gsm, unsigned int addr,
if (debug & DBG_ERRORS)
pr_info("%s unsupported I frame request in PN\n",
__func__);
+ gsm->unsupported++;
return -EINVAL;
default:
if (debug & DBG_ERRORS)
@@ -1896,6 +1897,8 @@ static void gsm_control_message(struct gsm_mux *gsm, unsigned int command,
/* Optional unsupported commands */
case CMD_RPN: /* Remote port negotiation */
case CMD_SNC: /* Service negotiation command */
+ gsm->unsupported++;
+ fallthrough;
default:
/* Reply to bad commands with an NSC */
buf[0] = command;
--
2.34.1
next prev parent reply other threads:[~2023-04-05 5:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 5:47 [PATCH 1/9] tty: n_gsm: fix redundant assignment of gsm->encoding D. Starke
2023-04-05 5:47 ` [PATCH 2/9] tty: n_gsm: add restart parameter to DLC specific ioctl config D. Starke
2023-04-05 8:15 ` Ilpo Järvinen
2023-04-06 5:17 ` Starke, Daniel
2023-04-05 5:47 ` [PATCH 3/9] tty: n_gsm: add missing description to gsm_config D. Starke
2023-04-05 8:18 ` Ilpo Järvinen
2023-04-06 5:26 ` Starke, Daniel
2023-04-05 5:47 ` [PATCH 4/9] tty: n_gsm: fix unneeded initialization of ret in gsm_dlci_config D. Starke
2023-04-05 8:23 ` Ilpo Järvinen
2023-04-06 5:31 ` Starke, Daniel
2023-04-05 5:47 ` [PATCH 5/9] tty: n_gsm: add open_error counter to gsm_mux D. Starke
2023-04-05 8:41 ` Ilpo Järvinen
2023-04-06 5:42 ` Starke, Daniel
2023-04-05 5:47 ` [PATCH 6/9] tty: n_gsm: increase malformed counter for malformed control frames D. Starke
2023-04-05 8:44 ` Ilpo Järvinen
2023-04-06 5:45 ` Starke, Daniel
2023-04-05 5:47 ` D. Starke [this message]
2023-04-05 9:00 ` [PATCH 7/9] tty: n_gsm: increase gsm_mux unsupported counted where appropriate Ilpo Järvinen
2023-04-06 5:57 ` Starke, Daniel
2023-04-05 5:47 ` [PATCH 8/9] tty: n_gsm: add DLCI specific rx/tx statistics D. Starke
2023-04-05 9:13 ` Ilpo Järvinen
2023-04-06 6:02 ` Starke, Daniel
2023-04-05 5:47 ` [PATCH 9/9] tty: n_gsm: cleanup gsm_control_command and gsm_control_reply D. Starke
2023-04-05 9:15 ` Ilpo Järvinen
2023-04-06 6:04 ` Starke, Daniel
2023-04-05 8:16 ` [PATCH 1/9] tty: n_gsm: fix redundant assignment of gsm->encoding Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230405054730.3850-7-daniel.starke@siemens.com \
--to=daniel.starke@siemens.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®