From: "Starke, Daniel" <daniel.starke@siemens.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: linux-serial <linux-serial@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/9] tty: n_gsm: add restart parameter to DLC specific ioctl config
Date: Thu, 6 Apr 2023 05:17:47 +0000 [thread overview]
Message-ID: <AS4PR10MB5895BA5B2ECFFF74DDBAB571E0919@AS4PR10MB5895.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <cd7c33c8-2634-382d-cf62-3785e391af2@linux.intel.com>
> > From: Daniel Starke <daniel.starke@siemens.com>
> >
> > 'gsm_config_ext' already allows to force a link reset via 'restart'
> > parameter.
>
> Please be more precise, there a function and struct with this name.
>
> HOWEVER, there is no such parameter in tty-next (am I looking from wrong
> repo??):
>
> static int gsm_config_ext(struct gsm_mux *gsm, struct gsm_config_ext *ce)
>
> ...nor here:
>
> struct gsm_config_ext {
> __u32 keep_alive; /* Control channel keep-alive in 1/100th of a
> * second (0 to disable)
> */
> __u32 wait_config; /* Wait for DLCI config before opening virtual link? */
> __u32 reserved[6]; /* For future use, must be initialized to zero */
> };
>
> ???
You are right. Looks like I was looking at the wrong branch. I will reword
the commit message and deliver the patch for 'struct gsm_config_ext'
afterwards.
Best regards,
Daniel Starke
next prev parent reply other threads:[~2023-04-06 5:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 5:47 [PATCH 1/9] tty: n_gsm: fix redundant assignment of gsm->encoding D. Starke
2023-04-05 5:47 ` [PATCH 2/9] tty: n_gsm: add restart parameter to DLC specific ioctl config D. Starke
2023-04-05 8:15 ` Ilpo Järvinen
2023-04-06 5:17 ` Starke, Daniel [this message]
2023-04-05 5:47 ` [PATCH 3/9] tty: n_gsm: add missing description to gsm_config D. Starke
2023-04-05 8:18 ` Ilpo Järvinen
2023-04-06 5:26 ` Starke, Daniel
2023-04-05 5:47 ` [PATCH 4/9] tty: n_gsm: fix unneeded initialization of ret in gsm_dlci_config D. Starke
2023-04-05 8:23 ` Ilpo Järvinen
2023-04-06 5:31 ` Starke, Daniel
2023-04-05 5:47 ` [PATCH 5/9] tty: n_gsm: add open_error counter to gsm_mux D. Starke
2023-04-05 8:41 ` Ilpo Järvinen
2023-04-06 5:42 ` Starke, Daniel
2023-04-05 5:47 ` [PATCH 6/9] tty: n_gsm: increase malformed counter for malformed control frames D. Starke
2023-04-05 8:44 ` Ilpo Järvinen
2023-04-06 5:45 ` Starke, Daniel
2023-04-05 5:47 ` [PATCH 7/9] tty: n_gsm: increase gsm_mux unsupported counted where appropriate D. Starke
2023-04-05 9:00 ` Ilpo Järvinen
2023-04-06 5:57 ` Starke, Daniel
2023-04-05 5:47 ` [PATCH 8/9] tty: n_gsm: add DLCI specific rx/tx statistics D. Starke
2023-04-05 9:13 ` Ilpo Järvinen
2023-04-06 6:02 ` Starke, Daniel
2023-04-05 5:47 ` [PATCH 9/9] tty: n_gsm: cleanup gsm_control_command and gsm_control_reply D. Starke
2023-04-05 9:15 ` Ilpo Järvinen
2023-04-06 6:04 ` Starke, Daniel
2023-04-05 8:16 ` [PATCH 1/9] tty: n_gsm: fix redundant assignment of gsm->encoding Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS4PR10MB5895BA5B2ECFFF74DDBAB571E0919@AS4PR10MB5895.EURPRD10.PROD.OUTLOOK.COM \
--to=daniel.starke@siemens.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®