* [PATCH] drm/amd/display: set variables aperture_default_system and context0_default_system storage-class-specifier to static
@ 2023-04-06 19:58 Tom Rix
2023-04-10 14:48 ` Hamza Mahfooz
0 siblings, 1 reply; 2+ messages in thread
From: Tom Rix @ 2023-04-06 19:58 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
christian.koenig, Xinhui.Pan, airlied, daniel, Brian.Chang,
Martin.Leung, David.Galiffi, Ethan.Wellenreiter, martin.tsai,
tales.aparecida
Cc: amd-gfx, dri-devel, linux-kernel, Tom Rix
smatch reports
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hubp.c:758:10: warning: symbol
'aperture_default_system' was not declared. Should it be static?
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hubp.c:759:10: warning: symbol
'context0_default_system' was not declared. Should it be static?
These variables are only used in one file so should be static.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c
index a142a00bc432..bf399819ca80 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c
@@ -755,8 +755,8 @@ bool hubp1_is_flip_pending(struct hubp *hubp)
return false;
}
-uint32_t aperture_default_system = 1;
-uint32_t context0_default_system; /* = 0;*/
+static uint32_t aperture_default_system = 1;
+static uint32_t context0_default_system; /* = 0;*/
static void hubp1_set_vm_system_aperture_settings(struct hubp *hubp,
struct vm_system_aperture_param *apt)
--
2.27.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amd/display: set variables aperture_default_system and context0_default_system storage-class-specifier to static
2023-04-06 19:58 [PATCH] drm/amd/display: set variables aperture_default_system and context0_default_system storage-class-specifier to static Tom Rix
@ 2023-04-10 14:48 ` Hamza Mahfooz
0 siblings, 0 replies; 2+ messages in thread
From: Hamza Mahfooz @ 2023-04-10 14:48 UTC (permalink / raw)
To: Tom Rix, harry.wentland, sunpeng.li, Rodrigo.Siqueira,
alexander.deucher, christian.koenig, Xinhui.Pan, airlied, daniel,
Brian.Chang, Martin.Leung, David.Galiffi, Ethan.Wellenreiter,
martin.tsai, tales.aparecida
Cc: dri-devel, amd-gfx, linux-kernel
On 4/6/23 15:58, Tom Rix wrote:
> smatch reports
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hubp.c:758:10: warning: symbol
> 'aperture_default_system' was not declared. Should it be static?
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hubp.c:759:10: warning: symbol
> 'context0_default_system' was not declared. Should it be static?
>
> These variables are only used in one file so should be static.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Applied, thanks!
> ---
> drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c
> index a142a00bc432..bf399819ca80 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c
> @@ -755,8 +755,8 @@ bool hubp1_is_flip_pending(struct hubp *hubp)
> return false;
> }
>
> -uint32_t aperture_default_system = 1;
> -uint32_t context0_default_system; /* = 0;*/
> +static uint32_t aperture_default_system = 1;
> +static uint32_t context0_default_system; /* = 0;*/
>
> static void hubp1_set_vm_system_aperture_settings(struct hubp *hubp,
> struct vm_system_aperture_param *apt)
--
Hamza
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-10 14:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-06 19:58 [PATCH] drm/amd/display: set variables aperture_default_system and context0_default_system storage-class-specifier to static Tom Rix
2023-04-10 14:48 ` Hamza Mahfooz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®