* [PATCH] Add Dell G15 5525 Ryzen Edition to quirks list for acp6x so that internal DMIC works.
@ 2023-04-10 15:49 Cem Kaya
2023-04-10 15:52 ` Limonciello, Mario
0 siblings, 1 reply; 2+ messages in thread
From: Cem Kaya @ 2023-04-10 15:49 UTC (permalink / raw)
To: perex, tiwai; +Cc: mario.limonciello, alsa-devel, linux-kernel, Cem Kaya
diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
index a428e17f0325..e044d811496e 100644
--- a/sound/soc/amd/yc/acp6x-mach.c
+++ b/sound/soc/amd/yc/acp6x-mach.c
@@ -45,6 +45,13 @@ static struct snd_soc_card acp6x_card = {
};
static const struct dmi_system_id yc_acp_quirk_table[] = {
+ {
+ .driver_data = &acp6x_card,
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "Dell Inc."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Dell G15 5525"),
+ }
+ },
{
.driver_data = &acp6x_card,
.matches = {
--
2.40.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [PATCH] Add Dell G15 5525 Ryzen Edition to quirks list for acp6x so that internal DMIC works.
2023-04-10 15:49 [PATCH] Add Dell G15 5525 Ryzen Edition to quirks list for acp6x so that internal DMIC works Cem Kaya
@ 2023-04-10 15:52 ` Limonciello, Mario
0 siblings, 0 replies; 2+ messages in thread
From: Limonciello, Mario @ 2023-04-10 15:52 UTC (permalink / raw)
To: Cem Kaya, perex, tiwai; +Cc: alsa-devel, linux-kernel
[Public]
> diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-
> mach.c
> index a428e17f0325..e044d811496e 100644
> --- a/sound/soc/amd/yc/acp6x-mach.c
> +++ b/sound/soc/amd/yc/acp6x-mach.c
> @@ -45,6 +45,13 @@ static struct snd_soc_card acp6x_card = {
> };
>
> static const struct dmi_system_id yc_acp_quirk_table[] = {
> + {
> + .driver_data = &acp6x_card,
> + .matches = {
> + DMI_MATCH(DMI_BOARD_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Dell G15
> 5525"),
> + }
> + },
> {
> .driver_data = &acp6x_card,
> .matches = {
> --
> 2.40.0
Hi,
Thanks for sending this up, but you'll need to add a few things:
1) You need to add a commit message explaining the why
2) You're missing a SoB tag (IE Signed-off-by: Foo Bar <foo@bar.com>)
3) As this came from a kernel Bugzilla originally, suggest you to add Link tag:
Link: https://foo.bar.com/url
4) When you resubmit, please change PATCH to "PATCH v2"
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-10 15:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-10 15:49 [PATCH] Add Dell G15 5525 Ryzen Edition to quirks list for acp6x so that internal DMIC works Cem Kaya
2023-04-10 15:52 ` Limonciello, Mario
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®