* [PATCH] accel/habanalabs: remove variable gaudi_irq_name
@ 2023-04-11 14:08 Tom Rix
2023-04-16 8:35 ` Oded Gabbay
0 siblings, 1 reply; 2+ messages in thread
From: Tom Rix @ 2023-04-11 14:08 UTC (permalink / raw)
To: ogabbay, gregkh, osharabi, talcohen, dhirschfeld, obitton
Cc: dri-devel, linux-kernel, Tom Rix
gcc with W=1 reports
drivers/accel/habanalabs/gaudi/gaudi.c:117:19: error:
‘gaudi_irq_name’ defined but not used [-Werror=unused-const-variable=]
117 | static const char gaudi_irq_name[GAUDI_MSI_ENTRIES][GAUDI_MAX_STRING_LEN] = {
| ^~~~~~~~~~~~~~
This variable is not used so remove it.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/accel/habanalabs/gaudi/gaudi.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/accel/habanalabs/gaudi/gaudi.c b/drivers/accel/habanalabs/gaudi/gaudi.c
index a29aa8f7b6f3..a1697581c218 100644
--- a/drivers/accel/habanalabs/gaudi/gaudi.c
+++ b/drivers/accel/habanalabs/gaudi/gaudi.c
@@ -114,13 +114,6 @@ static u32 gaudi_stream_master[GAUDI_STREAM_MASTER_ARR_SIZE] = {
GAUDI_QUEUE_ID_DMA_1_3
};
-static const char gaudi_irq_name[GAUDI_MSI_ENTRIES][GAUDI_MAX_STRING_LEN] = {
- "gaudi cq 0_0", "gaudi cq 0_1", "gaudi cq 0_2", "gaudi cq 0_3",
- "gaudi cq 1_0", "gaudi cq 1_1", "gaudi cq 1_2", "gaudi cq 1_3",
- "gaudi cq 5_0", "gaudi cq 5_1", "gaudi cq 5_2", "gaudi cq 5_3",
- "gaudi cpu eq"
-};
-
static const u8 gaudi_dma_assignment[GAUDI_DMA_MAX] = {
[GAUDI_PCI_DMA_1] = GAUDI_ENGINE_ID_DMA_0,
[GAUDI_PCI_DMA_2] = GAUDI_ENGINE_ID_DMA_1,
--
2.27.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] accel/habanalabs: remove variable gaudi_irq_name
2023-04-11 14:08 [PATCH] accel/habanalabs: remove variable gaudi_irq_name Tom Rix
@ 2023-04-16 8:35 ` Oded Gabbay
0 siblings, 0 replies; 2+ messages in thread
From: Oded Gabbay @ 2023-04-16 8:35 UTC (permalink / raw)
To: Tom Rix
Cc: gregkh, osharabi, talcohen, dhirschfeld, obitton, dri-devel,
linux-kernel
On Tue, Apr 11, 2023 at 5:09 PM Tom Rix <trix@redhat.com> wrote:
>
> gcc with W=1 reports
> drivers/accel/habanalabs/gaudi/gaudi.c:117:19: error:
> ‘gaudi_irq_name’ defined but not used [-Werror=unused-const-variable=]
> 117 | static const char gaudi_irq_name[GAUDI_MSI_ENTRIES][GAUDI_MAX_STRING_LEN] = {
> | ^~~~~~~~~~~~~~
>
> This variable is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/accel/habanalabs/gaudi/gaudi.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/accel/habanalabs/gaudi/gaudi.c b/drivers/accel/habanalabs/gaudi/gaudi.c
> index a29aa8f7b6f3..a1697581c218 100644
> --- a/drivers/accel/habanalabs/gaudi/gaudi.c
> +++ b/drivers/accel/habanalabs/gaudi/gaudi.c
> @@ -114,13 +114,6 @@ static u32 gaudi_stream_master[GAUDI_STREAM_MASTER_ARR_SIZE] = {
> GAUDI_QUEUE_ID_DMA_1_3
> };
>
> -static const char gaudi_irq_name[GAUDI_MSI_ENTRIES][GAUDI_MAX_STRING_LEN] = {
> - "gaudi cq 0_0", "gaudi cq 0_1", "gaudi cq 0_2", "gaudi cq 0_3",
> - "gaudi cq 1_0", "gaudi cq 1_1", "gaudi cq 1_2", "gaudi cq 1_3",
> - "gaudi cq 5_0", "gaudi cq 5_1", "gaudi cq 5_2", "gaudi cq 5_3",
> - "gaudi cpu eq"
> -};
> -
> static const u8 gaudi_dma_assignment[GAUDI_DMA_MAX] = {
> [GAUDI_PCI_DMA_1] = GAUDI_ENGINE_ID_DMA_0,
> [GAUDI_PCI_DMA_2] = GAUDI_ENGINE_ID_DMA_1,
> --
> 2.27.0
>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Applied to -next
Thanks,
Oded
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-16 8:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-11 14:08 [PATCH] accel/habanalabs: remove variable gaudi_irq_name Tom Rix
2023-04-16 8:35 ` Oded Gabbay
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®