From: Greg KH <gregkh@linuxfoundation.org>
To: Chuang Zhang <zhangchuang1909@gmail.com>
Cc: arve@android.com, tkjos@android.com, maco@android.com,
joel@joelfernandes.org, brauner@kernel.org, cmllamas@google.com,
surenb@google.com, linux-kernel@vger.kernel.org,
zhangchuang3 <zhangchuang3@xiaomi.com>
Subject: Re: [PATCH] BINDER:Allow tracing of binder_txn_latency_free
Date: Wed, 12 Apr 2023 08:45:04 +0200 [thread overview]
Message-ID: <2023041204-outreach-oppose-b2a3@gregkh> (raw)
In-Reply-To: <20230412033332.342521-1-zhangchuang1909@gmail.com>
On Wed, Apr 12, 2023 at 11:33:32AM +0800, Chuang Zhang wrote:
> From: zhangchuang3 <zhangchuang3@xiaomi.com>
>
> The author forgot to EXPORT and need Export
> binder_txn_latency_free trace point.
>
> Signed-off-by: zhangchuang3 <zhangchuang3@xiaomi.com>
I doubt you sign documents as "zhangchuang3", please always just use
your name, not your email alias.
And as this is coming from a gmail account, I can't ferify that this
really is an xiaomi.com address, why not just use your company address?
> ---
> drivers/android/binder.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index fb56bfc45096..320cf08805d4 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -6604,5 +6604,6 @@ device_initcall(binder_init);
>
> #define CREATE_TRACE_POINTS
> #include "binder_trace.h"
> +EXPORT_TRACEPOINT_SYMBOL_GPL(binder_txn_latency_free);
What in-kernel code needs this?
thanks,
greg k-h
prev parent reply other threads:[~2023-04-12 6:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 3:33 Chuang Zhang
2023-04-12 6:45 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023041204-outreach-oppose-b2a3@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=arve@android.com \
--cc=brauner@kernel.org \
--cc=cmllamas@google.com \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=surenb@google.com \
--cc=tkjos@android.com \
--cc=zhangchuang1909@gmail.com \
--cc=zhangchuang3@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®