mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] BINDER:Allow tracing of binder_txn_latency_free
@ 2023-04-12  3:33 Chuang Zhang
  2023-04-12  6:45 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Chuang Zhang @ 2023-04-12  3:33 UTC (permalink / raw)
  To: gregkh
  Cc: arve, tkjos, maco, joel, brauner, cmllamas, surenb, linux-kernel,
	zhangchuang3

From: zhangchuang3 <zhangchuang3@xiaomi.com>

The author forgot to EXPORT and need Export
binder_txn_latency_free trace point.

Signed-off-by: zhangchuang3 <zhangchuang3@xiaomi.com>
---
 drivers/android/binder.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index fb56bfc45096..320cf08805d4 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -6604,5 +6604,6 @@ device_initcall(binder_init);
 
 #define CREATE_TRACE_POINTS
 #include "binder_trace.h"
+EXPORT_TRACEPOINT_SYMBOL_GPL(binder_txn_latency_free);
 
 MODULE_LICENSE("GPL v2");
-- 
2.34.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] BINDER:Allow tracing of binder_txn_latency_free
  2023-04-12  3:33 [PATCH] BINDER:Allow tracing of binder_txn_latency_free Chuang Zhang
@ 2023-04-12  6:45 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2023-04-12  6:45 UTC (permalink / raw)
  To: Chuang Zhang
  Cc: arve, tkjos, maco, joel, brauner, cmllamas, surenb, linux-kernel,
	zhangchuang3

On Wed, Apr 12, 2023 at 11:33:32AM +0800, Chuang Zhang wrote:
> From: zhangchuang3 <zhangchuang3@xiaomi.com>
> 
> The author forgot to EXPORT and need Export
> binder_txn_latency_free trace point.
> 
> Signed-off-by: zhangchuang3 <zhangchuang3@xiaomi.com>

I doubt you sign documents as "zhangchuang3", please always just use
your name, not your email alias.

And as this is coming from a gmail account, I can't ferify that this
really is an xiaomi.com address, why not just use your company address?

> ---
>  drivers/android/binder.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index fb56bfc45096..320cf08805d4 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -6604,5 +6604,6 @@ device_initcall(binder_init);
>  
>  #define CREATE_TRACE_POINTS
>  #include "binder_trace.h"
> +EXPORT_TRACEPOINT_SYMBOL_GPL(binder_txn_latency_free);

What in-kernel code needs this?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-04-12  6:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-12  3:33 [PATCH] BINDER:Allow tracing of binder_txn_latency_free Chuang Zhang
2023-04-12  6:45 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®