From: Peter Zijlstra <peterz@infradead.org>
To: Josh Poimboeuf <jpoimboe@kernel.org>
Cc: Qi Zheng <zhengqi.arch@bytedance.com>,
keescook@chromium.org, dave.hansen@linux.intel.com, bp@alien8.de,
mingo@redhat.com, tglx@linutronix.de, rostedt@goodmis.org,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] x86: make __get_wchan() use arch_stack_walk()
Date: Wed, 12 Apr 2023 15:23:27 +0200 [thread overview]
Message-ID: <20230412132327.GA629496@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20230412131533.GH628377@hirez.programming.kicks-ass.net>
On Wed, Apr 12, 2023 at 03:15:33PM +0200, Peter Zijlstra wrote:
> On Fri, Apr 07, 2023 at 10:08:22PM -0700, Josh Poimboeuf wrote:
> > On Thu, Mar 30, 2023 at 04:15:52PM +0800, Qi Zheng wrote:
> > > Make __get_wchan() use arch_stack_walk() directly to
> > > avoid open-coding of unwind logic.
> > >
> > > Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com>
> >
> > Can we just have a shared version of __get_wchan() for all
> > CONFIG_ARCH_STACKWALK arches?
>
> Didn't I do that a while back ? I can't seem to actually find the
> patch-set though :/
Could be this series:
https://lkml.kernel.org/r/20211022150933.883959987@infradead.org
And this here:
https://lore.kernel.org/lkml/CAHk-=wjHbKfck1Ws4Y0pUZ7bxdjU9eh2WK0EFsv65utfeVkT9Q@mail.gmail.com/
might be why I dropped it.. I can't remember.
next prev parent reply other threads:[~2023-04-12 13:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 8:15 [PATCH 0/2] some fixes and cleanups for x86 Qi Zheng
2023-03-30 8:15 ` [PATCH 1/2] x86: make profile_pc() use arch_stack_walk() Qi Zheng
2023-04-08 4:56 ` Josh Poimboeuf
2023-04-08 5:26 ` Qi Zheng
2023-03-30 8:15 ` [PATCH 2/2] x86: make __get_wchan() " Qi Zheng
2023-04-08 5:08 ` Josh Poimboeuf
2023-04-08 5:36 ` Qi Zheng
2023-04-08 22:12 ` Josh Poimboeuf
2023-04-09 6:30 ` Qi Zheng
2023-04-12 5:20 ` Josh Poimboeuf
2023-04-12 7:10 ` Qi Zheng
2023-04-12 13:15 ` Peter Zijlstra
2023-04-12 13:23 ` Peter Zijlstra [this message]
2023-04-12 17:24 ` Qi Zheng
2023-04-07 3:47 ` [PATCH 0/2] some fixes and cleanups for x86 Qi Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230412132327.GA629496@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=jpoimboe@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®