* [PATCH] drm/amd/display: remove unused variable oldest_index
@ 2023-04-14 15:08 Tom Rix
2023-04-17 19:28 ` Alex Deucher
0 siblings, 1 reply; 2+ messages in thread
From: Tom Rix @ 2023-04-14 15:08 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
christian.koenig, Xinhui.Pan, airlied, daniel, HaoPing.Liu,
aric.cyr, qingqing.zhuo, hanghong.ma, felipe.clark,
Dillon.Varone, Mike.Hsieh
Cc: amd-gfx, dri-devel, linux-kernel, Tom Rix
cpp_check reports
drivers/gpu/drm/amd/display/modules/freesync/freesync.c:1143:17: style: Variable
'oldest_index' is assigned a value that is never used. [unreadVariable]
oldest_index = 0;
^
This variable is not used so remove.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/gpu/drm/amd/display/modules/freesync/freesync.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
index 5c41a4751db4..5798c0eafa1f 100644
--- a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
+++ b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
@@ -1137,10 +1137,6 @@ void mod_freesync_handle_preflip(struct mod_freesync *mod_freesync,
if (in_out_vrr->supported &&
in_out_vrr->state == VRR_STATE_ACTIVE_VARIABLE) {
- unsigned int oldest_index = plane->time.index + 1;
-
- if (oldest_index >= DC_PLANE_UPDATE_TIMES_MAX)
- oldest_index = 0;
last_render_time_in_us = curr_time_stamp_in_us -
plane->time.prev_update_time_in_us;
--
2.27.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] drm/amd/display: remove unused variable oldest_index
2023-04-14 15:08 [PATCH] drm/amd/display: remove unused variable oldest_index Tom Rix
@ 2023-04-17 19:28 ` Alex Deucher
0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2023-04-17 19:28 UTC (permalink / raw)
To: Tom Rix
Cc: harry.wentland, sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
christian.koenig, Xinhui.Pan, airlied, daniel, HaoPing.Liu,
aric.cyr, qingqing.zhuo, hanghong.ma, felipe.clark,
Dillon.Varone, Mike.Hsieh, dri-devel, amd-gfx, linux-kernel
Applied. Thanks!
On Fri, Apr 14, 2023 at 11:08 AM Tom Rix <trix@redhat.com> wrote:
>
> cpp_check reports
> drivers/gpu/drm/amd/display/modules/freesync/freesync.c:1143:17: style: Variable
> 'oldest_index' is assigned a value that is never used. [unreadVariable]
> oldest_index = 0;
> ^
>
> This variable is not used so remove.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/gpu/drm/amd/display/modules/freesync/freesync.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
> index 5c41a4751db4..5798c0eafa1f 100644
> --- a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
> +++ b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
> @@ -1137,10 +1137,6 @@ void mod_freesync_handle_preflip(struct mod_freesync *mod_freesync,
>
> if (in_out_vrr->supported &&
> in_out_vrr->state == VRR_STATE_ACTIVE_VARIABLE) {
> - unsigned int oldest_index = plane->time.index + 1;
> -
> - if (oldest_index >= DC_PLANE_UPDATE_TIMES_MAX)
> - oldest_index = 0;
>
> last_render_time_in_us = curr_time_stamp_in_us -
> plane->time.prev_update_time_in_us;
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-17 19:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-14 15:08 [PATCH] drm/amd/display: remove unused variable oldest_index Tom Rix
2023-04-17 19:28 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®