* Re: [PATCH -block] fault-inject: fix build error when FAULT_INJECTION_CONFIGFS=y and CONFIGFS_FS=m
2023-04-15 12:57 ` [PATCH -block] fault-inject: fix build error when FAULT_INJECTION_CONFIGFS=y and CONFIGFS_FS=m Akinobu Mita
@ 2023-04-15 20:40 ` Jens Axboe
2023-04-16 9:53 ` Geert Uytterhoeven
1 sibling, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2023-04-15 20:40 UTC (permalink / raw)
To: lkp, linux-block, linux-kernel, Akinobu Mita
Cc: oe-kbuild-all, shinichiro.kawasaki, chaitanyak, akpm, hch
On Sat, 15 Apr 2023 21:57:05 +0900, Akinobu Mita wrote:
> This fixes a build error when CONFIG_FAULT_INJECTION_CONFIGFS=y and
> CONFIG_CONFIGFS_FS=m.
>
> Since the fault-injection library cannot built as a module, avoid building
> configfs as a module.
>
>
> [...]
Applied, thanks!
[1/1] fault-inject: fix build error when FAULT_INJECTION_CONFIGFS=y and CONFIGFS_FS=m
commit: 5347c9321845e5a94be19ea951746d4f2b8b194f
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -block] fault-inject: fix build error when FAULT_INJECTION_CONFIGFS=y and CONFIGFS_FS=m
2023-04-15 12:57 ` [PATCH -block] fault-inject: fix build error when FAULT_INJECTION_CONFIGFS=y and CONFIGFS_FS=m Akinobu Mita
2023-04-15 20:40 ` Jens Axboe
@ 2023-04-16 9:53 ` Geert Uytterhoeven
2023-04-16 10:55 ` Arnd Bergmann
1 sibling, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2023-04-16 9:53 UTC (permalink / raw)
To: Akinobu Mita
Cc: lkp, linux-block, linux-kernel, axboe, oe-kbuild-all,
shinichiro.kawasaki, chaitanyak, akpm, hch, Arnd Bergmann
Hi Mita-san,
On Sat, Apr 15, 2023 at 3:09 PM Akinobu Mita <akinobu.mita@gmail.com> wrote:
> This fixes a build error when CONFIG_FAULT_INJECTION_CONFIGFS=y and
> CONFIG_CONFIGFS_FS=m.
>
> Since the fault-injection library cannot built as a module, avoid building
> configfs as a module.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202304150025.K0hczLR4-lkp@intel.com/
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Thanks for your patch!
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1979,7 +1979,8 @@ config FAIL_SUNRPC
>
> config FAULT_INJECTION_CONFIGFS
> bool "Configfs interface for fault-injection capabilities"
> - depends on FAULT_INJECTION && CONFIGFS_FS
> + depends on FAULT_INJECTION
> + select CONFIGFS_FS
My first thought was "please do not select CONFIGFS_FS", but
apparently this is what most users do, so I guess it's OK.
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
The alternative would be to do:
- depends on FAULT_INJECTION && CONFIGFS_FS
+ depends on FAULT_INJECTION && (CONFIGFS_FS=y ||
CONFIGFS_FS=FAULT_INJECTION)
> help
> This option allows configfs-based drivers to dynamically configure
> fault-injection via configfs. Each parameter for driver-specific
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread