* [PATCH] arm64: kexec: include reboot.h
@ 2023-04-18 11:54 Simon Horman
2023-04-20 17:04 ` Will Deacon
0 siblings, 1 reply; 2+ messages in thread
From: Simon Horman @ 2023-04-18 11:54 UTC (permalink / raw)
To: Catalin Marinas, Will Deacon
Cc: Baoquan He, Leizhen (ThunderTown), linux-arm-kernel, kexec, linux-kernel
Include reboot.h in machine_kexec.c for declaration of
machine_crash_shutdown.
gcc-12 with W=1 reports:
arch/arm64/kernel/machine_kexec.c:257:6: warning: no previous prototype for 'machine_crash_shutdown' [-Wmissing-prototypes]
257 | void machine_crash_shutdown(struct pt_regs *regs)
No functional changes intended.
Compile tested only.
Signed-off-by: Simon Horman <horms@kernel.org>
---
arch/arm64/kernel/machine_kexec.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/kernel/machine_kexec.c b/arch/arm64/kernel/machine_kexec.c
index 54f8e2d081c4..078910db77a4 100644
--- a/arch/arm64/kernel/machine_kexec.c
+++ b/arch/arm64/kernel/machine_kexec.c
@@ -11,6 +11,7 @@
#include <linux/kernel.h>
#include <linux/kexec.h>
#include <linux/page-flags.h>
+#include <linux/reboot.h>
#include <linux/set_memory.h>
#include <linux/smp.h>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: kexec: include reboot.h
2023-04-18 11:54 [PATCH] arm64: kexec: include reboot.h Simon Horman
@ 2023-04-20 17:04 ` Will Deacon
0 siblings, 0 replies; 2+ messages in thread
From: Will Deacon @ 2023-04-20 17:04 UTC (permalink / raw)
To: Catalin Marinas, Simon Horman
Cc: kernel-team, Will Deacon, linux-kernel, Baoquan He,
linux-arm-kernel, kexec, Leizhen (ThunderTown)
On Tue, 18 Apr 2023 13:54:00 +0200, Simon Horman wrote:
> Include reboot.h in machine_kexec.c for declaration of
> machine_crash_shutdown.
>
> gcc-12 with W=1 reports:
>
> arch/arm64/kernel/machine_kexec.c:257:6: warning: no previous prototype for 'machine_crash_shutdown' [-Wmissing-prototypes]
> 257 | void machine_crash_shutdown(struct pt_regs *regs)
>
> [...]
Applied to arm64 (for-next/misc), thanks!
[1/1] arm64: kexec: include reboot.h
https://git.kernel.org/arm64/c/b7b4ce84c830
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-20 17:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-18 11:54 [PATCH] arm64: kexec: include reboot.h Simon Horman
2023-04-20 17:04 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®