[PATCH v2] sh: pci: Remove unused variable in SH-7786 PCI Express code

[PATCH v2] sh: pci: Remove unused variable in SH-7786 PCI Express code

[John Paul Adrian Glaubitz]

Addresses the following warning when building sdk7786_defconfig:

arch/sh/drivers/pci/pcie-sh7786.c:34:22: warning: 'dma_pfn_offset' defined but not used [-Wunused-variable]
   34 | static unsigned long dma_pfn_offset;
      |                      ^~~~~~~~~~~~~~

Fixes: e0d072782c73 ("dma-mapping: introduce DMA range map, supplanting dma_pfn_offset")
Signed-off-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
---
v2:
- Fix formatting in commit message

 arch/sh/drivers/pci/pcie-sh7786.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/sh/drivers/pci/pcie-sh7786.c b/arch/sh/drivers/pci/pcie-sh7786.c
index b0c2a5238d04..39bb5038e1c6 100644
--- a/arch/sh/drivers/pci/pcie-sh7786.c
+++ b/arch/sh/drivers/pci/pcie-sh7786.c
@@ -31,7 +31,6 @@ struct sh7786_pcie_port {
 
 static struct sh7786_pcie_port *sh7786_pcie_ports;
 static unsigned int nr_ports;
-static unsigned long dma_pfn_offset;
 size_t memsize;
 u64 memstart;
 
-- 
2.39.2

Re: [PATCH v2] sh: pci: Remove unused variable in SH-7786 PCI Express code

[Geert Uytterhoeven]

On Wed, Apr 19, 2023 at 9:14 AM John Paul Adrian Glaubitz
<glaubitz@physik.fu-berlin.de> wrote:
> Addresses the following warning when building sdk7786_defconfig:
>
> arch/sh/drivers/pci/pcie-sh7786.c:34:22: warning: 'dma_pfn_offset' defined but not used [-Wunused-variable]
>    34 | static unsigned long dma_pfn_offset;
>       |                      ^~~~~~~~~~~~~~
>
> Fixes: e0d072782c73 ("dma-mapping: introduce DMA range map, supplanting dma_pfn_offset")
> Signed-off-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
> ---
> v2:
> - Fix formatting in commit message

My
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
on v1 is still valid.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2] sh: pci: Remove unused variable in SH-7786 PCI Express code

[John Paul Adrian Glaubitz]

On Wed, 2023-04-19 at 09:30 +0200, Geert Uytterhoeven wrote:
> On Wed, Apr 19, 2023 at 9:14 AM John Paul Adrian Glaubitz
> <glaubitz@physik.fu-berlin.de> wrote:
> > Addresses the following warning when building sdk7786_defconfig:
> > 
> > arch/sh/drivers/pci/pcie-sh7786.c:34:22: warning: 'dma_pfn_offset' defined but not used [-Wunused-variable]
> >    34 | static unsigned long dma_pfn_offset;
> >       |                      ^~~~~~~~~~~~~~
> > 
> > Fixes: e0d072782c73 ("dma-mapping: introduce DMA range map, supplanting dma_pfn_offset")
> > Signed-off-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
> > ---
> > v2:
> > - Fix formatting in commit message
> 
> My
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> on v1 is still valid.

Thanks, pushed to my for-next branch:

> https://git.kernel.org/pub/scm/linux/kernel/git/glaubitz/sh-linux.git/?h=for-next

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913