From: "D. Starke" <daniel.starke@siemens.com>
To: linux-serial@vger.kernel.org, gregkh@linuxfoundation.org,
jirislaby@kernel.org, ilpo.jarvinen@linux.intel.com
Cc: linux-kernel@vger.kernel.org, Daniel Starke <daniel.starke@siemens.com>
Subject: [PATCH v2 1/9] tty: n_gsm: fix redundant assignment of gsm->encoding
Date: Thu, 20 Apr 2023 10:50:09 +0200 [thread overview]
Message-ID: <20230420085017.7314-1-daniel.starke@siemens.com> (raw)
From: Daniel Starke <daniel.starke@siemens.com>
The function gsmld_open() contains a redundant assignment of gsm->encoding.
The same value of GSM_ADV_OPT is already assigned to it during the
initialization of the struct in gsm_alloc_mux() a few lines earlier.
Fix this by removing the redundant second assignment of gsm->encoding in
gsmld_open().
Fixes: e1eaea46bb40 ("tty: n_gsm line discipline")
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Daniel Starke <daniel.starke@siemens.com>
---
drivers/tty/n_gsm.c | 1 -
1 file changed, 1 deletion(-)
v1 -> v2:
Added Reviewed-by tag.
Link: https://lore.kernel.org/all/adf7aae2-2fd8-b191-f37-75185167f418@linux.intel.com/
diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index b7e1369a035c..c42c8b89fd46 100644
--- a/drivers/tty/n_gsm.c
+++ b/drivers/tty/n_gsm.c
@@ -3585,7 +3585,6 @@ static int gsmld_open(struct tty_struct *tty)
tty->receive_room = 65536;
/* Attach the initial passive connection */
- gsm->encoding = GSM_ADV_OPT;
gsmld_attach_gsm(tty, gsm);
/* The mux will not be activated yet, we wait for correct
--
2.34.1
next reply other threads:[~2023-04-20 8:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 8:50 D. Starke [this message]
2023-04-20 8:50 ` [PATCH v2 2/9] tty: n_gsm: add restart parameter to DLC specific ioctl config D. Starke
2023-04-20 8:50 ` [PATCH v2 3/9] tty: n_gsm: add missing description to gsm_config D. Starke
2023-04-20 9:08 ` Jiri Slaby
2023-04-20 11:11 ` Greg KH
2023-04-20 8:50 ` [PATCH v2 4/9] tty: n_gsm: remove unneeded initialization of ret in gsm_dlci_config D. Starke
2023-04-20 8:50 ` [PATCH v2 5/9] tty: n_gsm: add open_error counter to gsm_mux D. Starke
2023-04-20 8:50 ` [PATCH v2 6/9] tty: n_gsm: increase malformed counter for malformed control frames D. Starke
2023-04-20 8:50 ` [PATCH v2 7/9] tty: n_gsm: increase gsm_mux unsupported counted where appropriate D. Starke
2023-04-20 8:50 ` [PATCH v2 8/9] tty: n_gsm: cleanup gsm_control_command and gsm_control_reply D. Starke
2023-04-20 8:50 ` [PATCH v2 9/9] tty: n_gsm: add DLCI specific rx/tx statistics D. Starke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230420085017.7314-1-daniel.starke@siemens.com \
--to=daniel.starke@siemens.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®