mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "D. Starke" <daniel.starke@siemens.com>
To: linux-serial@vger.kernel.org, gregkh@linuxfoundation.org,
	jirislaby@kernel.org, ilpo.jarvinen@linux.intel.com
Cc: linux-kernel@vger.kernel.org, Daniel Starke <daniel.starke@siemens.com>
Subject: [PATCH v2 3/9] tty: n_gsm: add missing description to gsm_config
Date: Thu, 20 Apr 2023 10:50:11 +0200	[thread overview]
Message-ID: <20230420085017.7314-3-daniel.starke@siemens.com> (raw)
In-Reply-To: <20230420085017.7314-1-daniel.starke@siemens.com>

From: Daniel Starke <daniel.starke@siemens.com>

Currently, all available structure fields in gsmmux.h except those
for gsm_config are commented.

Fix this by adding appropriate comments to the not commented fields.
Note that 'mru' and 'mtu' refer to the size without basic/advanced option
mode header and byte stuffing as defined in the standard in chapter 5.7.2.

Link: https://portal.3gpp.org/desktopmodules/Specifications/SpecificationDetails.aspx?specificationId=1516
Signed-off-by: Daniel Starke <daniel.starke@siemens.com>
---
 include/uapi/linux/gsmmux.h | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

v1 -> v2:
Added remark regarding the mru/mtu size comment as this was unclear in the
review.

Link: https://lore.kernel.org/all/AS4PR10MB5895ADDAF211A669CCF7F8C5E0919@AS4PR10MB5895.EURPRD10.PROD.OUTLOOK.COM/

diff --git a/include/uapi/linux/gsmmux.h b/include/uapi/linux/gsmmux.h
index 33ee7b857c52..422a52e184b3 100644
--- a/include/uapi/linux/gsmmux.h
+++ b/include/uapi/linux/gsmmux.h
@@ -8,17 +8,17 @@
 
 struct gsm_config
 {
-	unsigned int adaption;
-	unsigned int encapsulation;
-	unsigned int initiator;
-	unsigned int t1;
-	unsigned int t2;
-	unsigned int t3;
-	unsigned int n2;
-	unsigned int mru;
-	unsigned int mtu;
-	unsigned int k;
-	unsigned int i;
+	unsigned int adaption;	/* Convergence layer type */
+	unsigned int encapsulation; /* Framing (0 = basic option, 1 = advanced option) */
+	unsigned int initiator;	/* Initiator or responder */
+	unsigned int t1;	/* Acknowledgment timer */
+	unsigned int t2;	/* Response timer for multiplexer control channel */
+	unsigned int t3;	/* Response timer for wake-up procedure */
+	unsigned int n2;	/* Maximum number of retransmissions */
+	unsigned int mru;	/* Maximum incoming frame payload size */
+	unsigned int mtu;	/* Maximum outgoing frame payload size */
+	unsigned int k;		/* Window size */
+	unsigned int i;		/* Frame type (1 = UIH, 2 = UI) */
 	unsigned int unused[8];	/* Can not be used */
 };
 
-- 
2.34.1


  parent reply	other threads:[~2023-04-20  8:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-20  8:50 [PATCH v2 1/9] tty: n_gsm: fix redundant assignment of gsm->encoding D. Starke
2023-04-20  8:50 ` [PATCH v2 2/9] tty: n_gsm: add restart parameter to DLC specific ioctl config D. Starke
2023-04-20  8:50 ` D. Starke [this message]
2023-04-20  9:08   ` [PATCH v2 3/9] tty: n_gsm: add missing description to gsm_config Jiri Slaby
2023-04-20 11:11     ` Greg KH
2023-04-20  8:50 ` [PATCH v2 4/9] tty: n_gsm: remove unneeded initialization of ret in gsm_dlci_config D. Starke
2023-04-20  8:50 ` [PATCH v2 5/9] tty: n_gsm: add open_error counter to gsm_mux D. Starke
2023-04-20  8:50 ` [PATCH v2 6/9] tty: n_gsm: increase malformed counter for malformed control frames D. Starke
2023-04-20  8:50 ` [PATCH v2 7/9] tty: n_gsm: increase gsm_mux unsupported counted where appropriate D. Starke
2023-04-20  8:50 ` [PATCH v2 8/9] tty: n_gsm: cleanup gsm_control_command and gsm_control_reply D. Starke
2023-04-20  8:50 ` [PATCH v2 9/9] tty: n_gsm: add DLCI specific rx/tx statistics D. Starke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230420085017.7314-3-daniel.starke@siemens.com \
    --to=daniel.starke@siemens.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®