mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kai-Heng Feng <kai.heng.feng@canonical.com>
To: bhelgaas@google.com
Cc: mika.westerberg@linux.intel.com, koba.ko@canonical.com,
	sathyanarayanan.kuppuswamy@linux.intel.com,
	Kai-Heng Feng <kai.heng.feng@canonical.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3 1/4] PCI: Keep AER status in pci_restore_state()
Date: Thu, 20 Apr 2023 20:59:37 +0800	[thread overview]
Message-ID: <20230420125941.333675-1-kai.heng.feng@canonical.com> (raw)

When AER is using the same IRQ as PME, AER interrupt is treated as a
wakeup event and it can disrupt system suspend process.

If that happens, the system will report it's woken up by PME IRQ without
indicating any AER error since AER status is cleared on resume.

So keep the AER status so users can know the system is woken up by AER
instead of PME.

Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
v3:
 - No change.

v2:
 - New patch.

 drivers/pci/pci.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 7a67611dc5f4..71aead00fc20 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -1778,7 +1778,6 @@ void pci_restore_state(struct pci_dev *dev)
 	pci_restore_dpc_state(dev);
 	pci_restore_ptm_state(dev);
 
-	pci_aer_clear_status(dev);
 	pci_restore_aer_state(dev);
 
 	pci_restore_config_space(dev);
-- 
2.34.1


             reply	other threads:[~2023-04-20 13:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-20 12:59 Kai-Heng Feng [this message]
2023-04-20 12:59 ` [PATCH v3 2/4] PCI/AER: Factor out interrupt toggling into helpers Kai-Heng Feng
2023-04-20 13:23   ` Mika Westerberg
2023-04-20 14:41   ` Sathyanarayanan Kuppuswamy
2023-04-20 12:59 ` [PATCH v3 3/4] PCI/AER: Disable AER interrupt on suspend Kai-Heng Feng
2023-04-20 14:53   ` Sathyanarayanan Kuppuswamy
2023-04-21  5:32     ` Kai-Heng Feng
2023-04-20 12:59 ` [PATCH v3 4/4] PCI/DPC: Disable DPC interrupt during suspend Kai-Heng Feng
2023-04-20 14:39 ` [PATCH v3 1/4] PCI: Keep AER status in pci_restore_state() Sathyanarayanan Kuppuswamy
2023-04-21  1:35   ` Kai-Heng Feng
2023-04-21  2:30     ` Sathyanarayanan Kuppuswamy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230420125941.333675-1-kai.heng.feng@canonical.com \
    --to=kai.heng.feng@canonical.com \
    --cc=bhelgaas@google.com \
    --cc=koba.ko@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®