* [PATCH] NFS: set varaiable nfs_netfs_debug_id storage-class-specifier to static
@ 2023-04-21 1:01 Tom Rix
0 siblings, 0 replies; only message in thread
From: Tom Rix @ 2023-04-21 1:01 UTC (permalink / raw)
To: trond.myklebust, anna; +Cc: linux-nfs, linux-kernel, Tom Rix
smatch reports
fs/nfs/fscache.c:260:10: warning: symbol
'nfs_netfs_debug_id' was not declared. Should it be static?
This variable is only used in its defining file, so it should be static
Signed-off-by: Tom Rix <trix@redhat.com>
---
fs/nfs/fscache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nfs/fscache.c b/fs/nfs/fscache.c
index 95c2b3056e2b..8c35d88a84b1 100644
--- a/fs/nfs/fscache.c
+++ b/fs/nfs/fscache.c
@@ -257,7 +257,7 @@ int nfs_netfs_readahead(struct readahead_control *ractl)
return 0;
}
-atomic_t nfs_netfs_debug_id;
+static atomic_t nfs_netfs_debug_id;
static int nfs_netfs_init_request(struct netfs_io_request *rreq, struct file *file)
{
rreq->netfs_priv = get_nfs_open_context(nfs_file_open_context(file));
--
2.27.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-04-21 1:02 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-21 1:01 [PATCH] NFS: set varaiable nfs_netfs_debug_id storage-class-specifier to static Tom Rix
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®