mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] ELF: use __builtin_mul_overflow() more
@ 2023-04-21 18:54 Alexey Dobriyan
  2023-04-21 19:39 ` Andrew Morton
  0 siblings, 1 reply; 3+ messages in thread
From: Alexey Dobriyan @ 2023-04-21 18:54 UTC (permalink / raw)
  To: akpm; +Cc: linux-kernel

__builtin_mul_overflow() can do multiplication and overflow check
in one line.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

 fs/binfmt_elf.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/fs/binfmt_elf.c
+++ b/fs/binfmt_elf.c
@@ -1651,9 +1651,8 @@ static int fill_files_note(struct memelfnote *note, struct coredump_params *cprm
 
 	/* *Estimated* file count and total data size needed */
 	count = cprm->vma_count;
-	if (count > UINT_MAX / 64)
+	if (__builtin_mul_overflow(count, 64, &size))
 		return -EINVAL;
-	size = count * 64;
 
 	names_ofs = (2 + 3 * count) * sizeof(data[0]);
  alloc:

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-04-22  9:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-21 18:54 [PATCH] ELF: use __builtin_mul_overflow() more Alexey Dobriyan
2023-04-21 19:39 ` Andrew Morton
2023-04-22  9:45   ` Alexey Dobriyan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®