From: Ravi Bangoria <ravi.bangoria@amd.com>
To: <peterz@infradead.org>
Cc: <ravi.bangoria@amd.com>, <namhyung@kernel.org>,
<eranian@google.com>, <acme@kernel.org>, <mark.rutland@arm.com>,
<jolsa@kernel.org>, <irogers@google.com>, <bp@alien8.de>,
<kan.liang@linux.intel.com>, <adrian.hunter@intel.com>,
<maddy@linux.ibm.com>, <x86@kernel.org>,
<linux-perf-users@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <sandipan.das@amd.com>,
<ananth.narayan@amd.com>, <santosh.shukla@amd.com>
Subject: [PATCH v3 0/3] perf: Rework event forwarding logic
Date: Tue, 25 Apr 2023 19:52:02 +0530 [thread overview]
Message-ID: <20230425142205.762-1-ravi.bangoria@amd.com> (raw)
Usually events are opened on the same pmu as requested by user via
perf_event_attr->type argument. But certain special events are
internally redirected to different pmu. Currently such pmus needs to
be treated specially and thus requires some gruesome hacks.
An approach, suggested by Peter Zijlstra, to get rid of these hacks
was to overwrite event attributes with new pmu's attribute values
within the kernel and let perf_event_init() retry opening the event
with overwritten values. This patch series implements it.
v2: https://lore.kernel.org/r/20230309101111.444-1-ravi.bangoria@amd.com
v2->v3:
- Both uses different approach to solve the problem. v2 was using new
error value -ESRCH to let perf_event_init() try opening event with
all pmus, hoping that the event will get forwarded to right pmu.
OTOH, v3 uses different approach as described in the description.
- v3 also fixes SW pmu to task-clock/cpu-clock pmu event forwarding.
Patches are prepared on v6.3.
Ravi Bangoria (3):
perf/core: Rework forwarding of {task|cpu}-clock events
perf/ibs: Fix interface via core pmu events
perf test: Add selftest to test IBS invocation via core pmu events
arch/x86/events/amd/core.c | 2 +-
arch/x86/events/amd/ibs.c | 53 ++++++++---------
arch/x86/include/asm/perf_event.h | 2 +
include/linux/perf_event.h | 11 ++++
kernel/events/core.c | 79 +++++++++++--------------
tools/perf/tests/Build | 1 +
tools/perf/tests/amd-ibs-via-core-pmu.c | 72 ++++++++++++++++++++++
tools/perf/tests/builtin-test.c | 1 +
tools/perf/tests/tests.h | 1 +
9 files changed, 151 insertions(+), 71 deletions(-)
create mode 100644 tools/perf/tests/amd-ibs-via-core-pmu.c
--
2.40.0
next reply other threads:[~2023-04-25 14:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 14:22 Ravi Bangoria [this message]
2023-04-25 14:22 ` [PATCH v3 1/3] perf/core: Rework forwarding of {task|cpu}-clock events Ravi Bangoria
2023-05-02 15:34 ` Peter Zijlstra
2023-05-03 8:32 ` Ravi Bangoria
2023-04-25 14:22 ` [PATCH v3 2/3] perf/ibs: Fix interface via core pmu events Ravi Bangoria
2023-05-02 15:37 ` Peter Zijlstra
2023-05-03 8:33 ` Ravi Bangoria
2023-04-25 14:22 ` [PATCH v3 3/3] perf test: Add selftest to test IBS invocation " Ravi Bangoria
2023-04-29 21:09 ` Ian Rogers
2023-05-02 3:08 ` Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230425142205.762-1-ravi.bangoria@amd.com \
--to=ravi.bangoria@amd.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ananth.narayan@amd.com \
--cc=bp@alien8.de \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=maddy@linux.ibm.com \
--cc=mark.rutland@arm.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=sandipan.das@amd.com \
--cc=santosh.shukla@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®