mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joy Chakraborty <joychakr@google.com>
To: Serge Semin <fancer.lancer@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
	manugautam@google.com, rohitner@google.com,
	Joy Chakraborty <joychakr@google.com>
Subject: [PATCH v9 1/5] spi: dw: Add 32 bpw support to SPI DW DMA driver
Date: Thu, 27 Apr 2023 12:33:10 +0000	[thread overview]
Message-ID: <20230427123314.1997152-2-joychakr@google.com> (raw)
In-Reply-To: <20230427123314.1997152-1-joychakr@google.com>

Add Support for AxSize = 4 bytes configuration from dw dma driver if
n_bytes i.e. number of bytes per write to fifo is 4.

Number of bytes written to fifo per write is depended on the bits/word
configuration being used which the DW core driver translates to n_bytes.
Hence, for bits per word values between 17 and 32 n_bytes should be
equal to 4.

Signed-off-by: Joy Chakraborty <joychakr@google.com>
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
Tested-by: Serge Semin <fancer.lancer@gmail.com>
* tested on Baikal-T1 based system with DW SPI-looped back interface
transferring a chunk of data with DFS:8,12,16.
---
 drivers/spi/spi-dw-dma.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/spi/spi-dw-dma.c b/drivers/spi/spi-dw-dma.c
index ababb910b391..c1b42cb59965 100644
--- a/drivers/spi/spi-dw-dma.c
+++ b/drivers/spi/spi-dw-dma.c
@@ -208,12 +208,16 @@ static bool dw_spi_can_dma(struct spi_controller *master,
 
 static enum dma_slave_buswidth dw_spi_dma_convert_width(u8 n_bytes)
 {
-	if (n_bytes == 1)
+	switch (n_bytes) {
+	case 1:
 		return DMA_SLAVE_BUSWIDTH_1_BYTE;
-	else if (n_bytes == 2)
+	case 2:
 		return DMA_SLAVE_BUSWIDTH_2_BYTES;
-
-	return DMA_SLAVE_BUSWIDTH_UNDEFINED;
+	case 4:
+		return DMA_SLAVE_BUSWIDTH_4_BYTES;
+	default:
+		return DMA_SLAVE_BUSWIDTH_UNDEFINED;
+	}
 }
 
 static int dw_spi_dma_wait(struct dw_spi *dws, unsigned int len, u32 speed)
-- 
2.40.1.495.gc816e09b53d-goog


  reply	other threads:[~2023-04-27 12:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-27 12:33 [PATCH v9 0/5] spi: dw: DW SPI DMA Driver updates Joy Chakraborty
2023-04-27 12:33 ` Joy Chakraborty [this message]
2023-04-27 12:33 ` [PATCH v9 2/5] spi: dw: Move dw_spi_can_dma() Joy Chakraborty
2023-04-27 12:33 ` [PATCH v9 3/5] spi: dw: Add DMA directional capability check Joy Chakraborty
2023-04-27 12:33 ` [PATCH v9 4/5] spi: dw: Add DMA address widths " Joy Chakraborty
2023-05-08 13:16   ` Mark Brown
2023-05-09  8:25     ` Joy Chakraborty
2023-04-27 12:33 ` [PATCH v9 5/5] spi: dw: Round of n_bytes to power of 2 Joy Chakraborty
2023-05-01 17:14 ` [PATCH v9 0/5] spi: dw: DW SPI DMA Driver updates Serge Semin
2023-05-01 23:58   ` Mark Brown
2023-05-02  0:44     ` Serge Semin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230427123314.1997152-2-joychakr@google.com \
    --to=joychakr@google.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=broonie@kernel.org \
    --cc=fancer.lancer@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=manugautam@google.com \
    --cc=rohitner@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®