mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joy Chakraborty <joychakr@google.com>
To: Serge Semin <fancer.lancer@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
	manugautam@google.com, rohitner@google.com,
	Joy Chakraborty <joychakr@google.com>
Subject: [PATCH v9 5/5] spi: dw: Round of n_bytes to power of 2
Date: Thu, 27 Apr 2023 12:33:14 +0000	[thread overview]
Message-ID: <20230427123314.1997152-6-joychakr@google.com> (raw)
In-Reply-To: <20230427123314.1997152-1-joychakr@google.com>

n_bytes variable in the driver represents the number of bytes per word
that needs to be sent/copied to fifo. Bits/word can be between 8 and 32
bits from the client but in memory they are a power of 2, same is mentioned
in spi.h header:
"
 * @bits_per_word: Data transfers involve one or more words; word sizes
 *	like eight or 12 bits are common.  In-memory wordsizes are
 *	powers of two bytes (e.g. 20 bit samples use 32 bits).
 *	This may be changed by the device's driver, or left at the
 *	default (0) indicating protocol words are eight bit bytes.
 *	The spi_transfer.bits_per_word can override this for each transfer.
"

Hence, round of n_bytes to a power of 2 to avoid values like 3 which
would generate unalligned/odd accesses to memory/fifo.

Fixes: a51acc2400d4 ("spi: dw: Add support for 32-bits max xfer size")
Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Joy Chakraborty <joychakr@google.com>
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
Tested-by: Serge Semin <fancer.lancer@gmail.com>
* tested on Baikal-T1 based system with DW SPI-looped back interface
transferring a chunk of data with DFS:8,12,16.
---
 drivers/spi/spi-dw-core.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/spi/spi-dw-core.c b/drivers/spi/spi-dw-core.c
index c3bfb6c84cab..4976e3b8923e 100644
--- a/drivers/spi/spi-dw-core.c
+++ b/drivers/spi/spi-dw-core.c
@@ -426,7 +426,10 @@ static int dw_spi_transfer_one(struct spi_controller *master,
 	int ret;
 
 	dws->dma_mapped = 0;
-	dws->n_bytes = DIV_ROUND_UP(transfer->bits_per_word, BITS_PER_BYTE);
+	dws->n_bytes =
+		roundup_pow_of_two(DIV_ROUND_UP(transfer->bits_per_word,
+						BITS_PER_BYTE));
+
 	dws->tx = (void *)transfer->tx_buf;
 	dws->tx_len = transfer->len / dws->n_bytes;
 	dws->rx = transfer->rx_buf;
-- 
2.40.1.495.gc816e09b53d-goog


  parent reply	other threads:[~2023-04-27 12:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-27 12:33 [PATCH v9 0/5] spi: dw: DW SPI DMA Driver updates Joy Chakraborty
2023-04-27 12:33 ` [PATCH v9 1/5] spi: dw: Add 32 bpw support to SPI DW DMA driver Joy Chakraborty
2023-04-27 12:33 ` [PATCH v9 2/5] spi: dw: Move dw_spi_can_dma() Joy Chakraborty
2023-04-27 12:33 ` [PATCH v9 3/5] spi: dw: Add DMA directional capability check Joy Chakraborty
2023-04-27 12:33 ` [PATCH v9 4/5] spi: dw: Add DMA address widths " Joy Chakraborty
2023-05-08 13:16   ` Mark Brown
2023-05-09  8:25     ` Joy Chakraborty
2023-04-27 12:33 ` Joy Chakraborty [this message]
2023-05-01 17:14 ` [PATCH v9 0/5] spi: dw: DW SPI DMA Driver updates Serge Semin
2023-05-01 23:58   ` Mark Brown
2023-05-02  0:44     ` Serge Semin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230427123314.1997152-6-joychakr@google.com \
    --to=joychakr@google.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=broonie@kernel.org \
    --cc=fancer.lancer@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=manugautam@google.com \
    --cc=rohitner@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®