* [PATCH -next] gpio: ixp4xx: Use devm_platform_ioremap_resource()
@ 2023-04-28 6:09 Yang Li
2023-05-11 9:08 ` Bartosz Golaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2023-04-28 6:09 UTC (permalink / raw)
To: linusw
Cc: kaloz, khalasa, brgl, linux-arm-kernel, linux-gpio, linux-kernel,
Yang Li
Convert platform_get_resource(),devm_ioremap_resource() to a single
call to devm_platform_ioremap_resource(), as this is exactly what this
function does.
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/gpio/gpio-ixp4xx.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpio/gpio-ixp4xx.c b/drivers/gpio/gpio-ixp4xx.c
index 56656fb519f8..1e29de1671d4 100644
--- a/drivers/gpio/gpio-ixp4xx.c
+++ b/drivers/gpio/gpio-ixp4xx.c
@@ -199,7 +199,6 @@ static int ixp4xx_gpio_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev;
struct device_node *np = dev->of_node;
struct irq_domain *parent;
- struct resource *res;
struct ixp4xx_gpio *g;
struct gpio_irq_chip *girq;
struct device_node *irq_parent;
@@ -210,8 +209,7 @@ static int ixp4xx_gpio_probe(struct platform_device *pdev)
return -ENOMEM;
g->dev = dev;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- g->base = devm_ioremap_resource(dev, res);
+ g->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(g->base))
return PTR_ERR(g->base);
--
2.20.1.7.g153144c
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] gpio: ixp4xx: Use devm_platform_ioremap_resource()
2023-04-28 6:09 [PATCH -next] gpio: ixp4xx: Use devm_platform_ioremap_resource() Yang Li
@ 2023-05-11 9:08 ` Bartosz Golaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Bartosz Golaszewski @ 2023-05-11 9:08 UTC (permalink / raw)
To: Yang Li
Cc: linusw, kaloz, khalasa, linux-arm-kernel, linux-gpio, linux-kernel
On Fri, Apr 28, 2023 at 8:09 AM Yang Li <yang.lee@linux.alibaba.com> wrote:
>
> Convert platform_get_resource(),devm_ioremap_resource() to a single
> call to devm_platform_ioremap_resource(), as this is exactly what this
> function does.
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/gpio/gpio-ixp4xx.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpio-ixp4xx.c b/drivers/gpio/gpio-ixp4xx.c
> index 56656fb519f8..1e29de1671d4 100644
> --- a/drivers/gpio/gpio-ixp4xx.c
> +++ b/drivers/gpio/gpio-ixp4xx.c
> @@ -199,7 +199,6 @@ static int ixp4xx_gpio_probe(struct platform_device *pdev)
> struct device *dev = &pdev->dev;
> struct device_node *np = dev->of_node;
> struct irq_domain *parent;
> - struct resource *res;
> struct ixp4xx_gpio *g;
> struct gpio_irq_chip *girq;
> struct device_node *irq_parent;
> @@ -210,8 +209,7 @@ static int ixp4xx_gpio_probe(struct platform_device *pdev)
> return -ENOMEM;
> g->dev = dev;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - g->base = devm_ioremap_resource(dev, res);
> + g->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(g->base))
> return PTR_ERR(g->base);
>
> --
> 2.20.1.7.g153144c
>
Applied, thanks!
Bart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-11 9:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-28 6:09 [PATCH -next] gpio: ixp4xx: Use devm_platform_ioremap_resource() Yang Li
2023-05-11 9:08 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®