* [PATCH] iio: adc: palmas: Remove the unneeded include <linux/i2c.h>
@ 2023-04-24 7:11 Christophe JAILLET
2023-04-30 17:04 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2023-04-24 7:11 UTC (permalink / raw)
To: Jonathan Cameron, Lars-Peter Clausen
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, linux-iio
This driver does not use i2c, so there is no point in including
<linux/i2c.h>
Remove it.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/iio/adc/palmas_gpadc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/iio/adc/palmas_gpadc.c b/drivers/iio/adc/palmas_gpadc.c
index c1c439215aeb..42c519504529 100644
--- a/drivers/iio/adc/palmas_gpadc.c
+++ b/drivers/iio/adc/palmas_gpadc.c
@@ -14,7 +14,6 @@
#include <linux/platform_device.h>
#include <linux/slab.h>
#include <linux/delay.h>
-#include <linux/i2c.h>
#include <linux/pm.h>
#include <linux/mfd/palmas.h>
#include <linux/completion.h>
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: adc: palmas: Remove the unneeded include <linux/i2c.h>
2023-04-24 7:11 [PATCH] iio: adc: palmas: Remove the unneeded include <linux/i2c.h> Christophe JAILLET
@ 2023-04-30 17:04 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2023-04-30 17:04 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Lars-Peter Clausen, linux-kernel, kernel-janitors, linux-iio
On Mon, 24 Apr 2023 09:11:51 +0200
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> This driver does not use i2c, so there is no point in including
> <linux/i2c.h>
>
> Remove it.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Hard to argue with that logic :)
I guess some long ago cut and paste..
Applied,
Thanks,
Jonathan
> ---
> drivers/iio/adc/palmas_gpadc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/adc/palmas_gpadc.c b/drivers/iio/adc/palmas_gpadc.c
> index c1c439215aeb..42c519504529 100644
> --- a/drivers/iio/adc/palmas_gpadc.c
> +++ b/drivers/iio/adc/palmas_gpadc.c
> @@ -14,7 +14,6 @@
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> #include <linux/delay.h>
> -#include <linux/i2c.h>
> #include <linux/pm.h>
> #include <linux/mfd/palmas.h>
> #include <linux/completion.h>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-30 16:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-24 7:11 [PATCH] iio: adc: palmas: Remove the unneeded include <linux/i2c.h> Christophe JAILLET
2023-04-30 17:04 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®