* [PATCH] sched: core: Simplify init_sched_mm_cid()
@ 2023-05-07 2:33 Li kunyu
2023-05-07 2:04 ` Steven Rostedt
0 siblings, 1 reply; 2+ messages in thread
From: Li kunyu @ 2023-05-07 2:33 UTC (permalink / raw)
To: mingo, peterz, juri.lelli, vincent.guittot, dietmar.eggemann,
rostedt, bsegall, mgorman, bristot, vschneid
Cc: linux-kernel, Li kunyu
int mm_users variable definition move to variable usage location.
Signed-off-by: Li kunyu <kunyu@nfschina.com>
---
kernel/sched/core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index f341e2100304..a66960da3f5c 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -11910,10 +11910,9 @@ static void task_mm_cid_work(struct callback_head *work)
void init_sched_mm_cid(struct task_struct *t)
{
struct mm_struct *mm = t->mm;
- int mm_users = 0;
if (mm) {
- mm_users = atomic_read(&mm->mm_users);
+ int mm_users = atomic_read(&mm->mm_users);
if (mm_users == 1)
mm->mm_cid_next_scan = jiffies + msecs_to_jiffies(MM_CID_SCAN_DELAY);
}
--
2.18.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] sched: core: Simplify init_sched_mm_cid()
2023-05-07 2:33 [PATCH] sched: core: Simplify init_sched_mm_cid() Li kunyu
@ 2023-05-07 2:04 ` Steven Rostedt
0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2023-05-07 2:04 UTC (permalink / raw)
To: Li kunyu
Cc: mingo, peterz, juri.lelli, vincent.guittot, dietmar.eggemann,
bsegall, mgorman, bristot, vschneid, linux-kernel
On Sun, 7 May 2023 10:33:52 +0800
Li kunyu <kunyu@nfschina.com> wrote:
> int mm_users variable definition move to variable usage location.
Why?
>
> Signed-off-by: Li kunyu <kunyu@nfschina.com>
> ---
> kernel/sched/core.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index f341e2100304..a66960da3f5c 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -11910,10 +11910,9 @@ static void task_mm_cid_work(struct callback_head *work)
> void init_sched_mm_cid(struct task_struct *t)
> {
> struct mm_struct *mm = t->mm;
> - int mm_users = 0;
>
> if (mm) {
> - mm_users = atomic_read(&mm->mm_users);
> + int mm_users = atomic_read(&mm->mm_users);
This is not a requirement, and not everyone prefers this method.
If anything, a real cleanup would simply be to remove the "= 0" and
just have it be:
int mm_users;
As there's no reason to initialize it to zero.
-- Steve
> if (mm_users == 1)
> mm->mm_cid_next_scan = jiffies + msecs_to_jiffies(MM_CID_SCAN_DELAY);
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-07 2:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-07 2:33 [PATCH] sched: core: Simplify init_sched_mm_cid() Li kunyu
2023-05-07 2:04 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®