* [PATCH] ARM: s3c: remove obsolete config S3C64XX_SETUP_IDE
@ 2023-05-08 4:04 Lukas Bulwahn
2023-05-08 5:38 ` Arnd Bergmann
2023-05-08 9:01 ` Krzysztof Kozlowski
0 siblings, 2 replies; 3+ messages in thread
From: Lukas Bulwahn @ 2023-05-08 4:04 UTC (permalink / raw)
To: Russell King, Krzysztof Kozlowski, Alim Akhtar, linux-arm-kernel,
linux-samsung-soc, Arnd Bergmann, soc
Cc: kernel-janitors, linux-kernel, Lukas Bulwahn
Commit 0d297df03890 ("ARM: s3c: simplify platform code") removes the line
in Makefile.s3c64xx to configure the inclusion of setup-ide-s3c64xx.c,
with CONFIG_S3C64XX_SETUP_IDE. So, since then, config S3C64XX_SETUP_IDE has
no effect and any further purpose.
Remove the obsolete config S3C64XX_SETUP_IDE.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
arch/arm/mach-s3c/Kconfig.s3c64xx | 6 ------
1 file changed, 6 deletions(-)
diff --git a/arch/arm/mach-s3c/Kconfig.s3c64xx b/arch/arm/mach-s3c/Kconfig.s3c64xx
index 01a7a8eec6e8..8f40af063ad6 100644
--- a/arch/arm/mach-s3c/Kconfig.s3c64xx
+++ b/arch/arm/mach-s3c/Kconfig.s3c64xx
@@ -69,11 +69,6 @@ config S3C64XX_SETUP_I2C1
help
Common setup code for i2c bus 1.
-config S3C64XX_SETUP_IDE
- bool
- help
- Common setup code for S3C64XX IDE.
-
config S3C64XX_SETUP_FB_24BPP
bool
help
@@ -110,7 +105,6 @@ config MACH_WLF_CRAGG_6410
select S3C64XX_DEV_SPI0
select S3C64XX_SETUP_FB_24BPP
select S3C64XX_SETUP_I2C1
- select S3C64XX_SETUP_IDE
select S3C64XX_SETUP_KEYPAD
select S3C64XX_SETUP_SDHCI
select S3C64XX_SETUP_SPI
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: s3c: remove obsolete config S3C64XX_SETUP_IDE
2023-05-08 4:04 [PATCH] ARM: s3c: remove obsolete config S3C64XX_SETUP_IDE Lukas Bulwahn
@ 2023-05-08 5:38 ` Arnd Bergmann
2023-05-08 9:01 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2023-05-08 5:38 UTC (permalink / raw)
To: Lukas Bulwahn, Russell King, Krzysztof Kozlowski, Alim Akhtar,
linux-arm-kernel, linux-samsung-soc, soc
Cc: kernel-janitors, linux-kernel
On Mon, May 8, 2023, at 06:04, Lukas Bulwahn wrote:
> Commit 0d297df03890 ("ARM: s3c: simplify platform code") removes the line
> in Makefile.s3c64xx to configure the inclusion of setup-ide-s3c64xx.c,
> with CONFIG_S3C64XX_SETUP_IDE. So, since then, config S3C64XX_SETUP_IDE has
> no effect and any further purpose.
>
> Remove the obsolete config S3C64XX_SETUP_IDE.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Indeed, this was only used on the smdk64xx board file,
so the file was removed along with the deletion of the board,
but I forgot to remove the Kconfig option.
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: s3c: remove obsolete config S3C64XX_SETUP_IDE
2023-05-08 4:04 [PATCH] ARM: s3c: remove obsolete config S3C64XX_SETUP_IDE Lukas Bulwahn
2023-05-08 5:38 ` Arnd Bergmann
@ 2023-05-08 9:01 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-05-08 9:01 UTC (permalink / raw)
To: Russell King, Alim Akhtar, linux-arm-kernel, linux-samsung-soc,
Arnd Bergmann, soc, Lukas Bulwahn
Cc: Krzysztof Kozlowski, kernel-janitors, linux-kernel
On Mon, 08 May 2023 06:04:33 +0200, Lukas Bulwahn wrote:
> Commit 0d297df03890 ("ARM: s3c: simplify platform code") removes the line
> in Makefile.s3c64xx to configure the inclusion of setup-ide-s3c64xx.c,
> with CONFIG_S3C64XX_SETUP_IDE. So, since then, config S3C64XX_SETUP_IDE has
> no effect and any further purpose.
>
> Remove the obsolete config S3C64XX_SETUP_IDE.
>
> [...]
Applied, thanks!
[1/1] ARM: s3c: remove obsolete config S3C64XX_SETUP_IDE
https://git.kernel.org/krzk/linux/c/9d2edccb154bd98baf7f1e21d23f799e4f5e8359
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-08 9:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-08 4:04 [PATCH] ARM: s3c: remove obsolete config S3C64XX_SETUP_IDE Lukas Bulwahn
2023-05-08 5:38 ` Arnd Bergmann
2023-05-08 9:01 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®