mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Tejun Heo <tj@kernel.org>
Cc: jiangshanlai@gmail.com, linux-kernel@vger.kernel.org,
	kernel-team@meta.com, Wang Yugui <wangyugui@e16-tech.com>,
	Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
	David Sterba <dsterba@suse.com>,
	linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 08/13] btrfs: Use alloc_ordered_workqueue() to create ordered workqueues
Date: Tue, 9 May 2023 16:53:32 +0200	[thread overview]
Message-ID: <20230509145332.GA32559@twin.jikos.cz> (raw)
In-Reply-To: <20230509015032.3768622-9-tj@kernel.org>

On Mon, May 08, 2023 at 03:50:27PM -1000, Tejun Heo wrote:
> BACKGROUND
> ==========
> 
> When multiple work items are queued to a workqueue, their execution order
> doesn't match the queueing order. They may get executed in any order and
> simultaneously. When fully serialized execution - one by one in the queueing
> order - is needed, an ordered workqueue should be used which can be created
> with alloc_ordered_workqueue().
> 
> However, alloc_ordered_workqueue() was a later addition. Before it, an
> ordered workqueue could be obtained by creating an UNBOUND workqueue with
> @max_active==1. This originally was an implementation side-effect which was
> broken by 4c16bd327c74 ("workqueue: restore WQ_UNBOUND/max_active==1 to be
> ordered"). Because there were users that depended on the ordered execution,
> 5c0338c68706 ("workqueue: restore WQ_UNBOUND/max_active==1 to be ordered")
> made workqueue allocation path to implicitly promote UNBOUND workqueues w/
> @max_active==1 to ordered workqueues.
> 
> While this has worked okay, overloading the UNBOUND allocation interface
> this way creates other issues. It's difficult to tell whether a given
> workqueue actually needs to be ordered and users that legitimately want a
> min concurrency level wq unexpectedly gets an ordered one instead. With
> planned UNBOUND workqueue updates to improve execution locality and more
> prevalence of chiplet designs which can benefit from such improvements, this
> isn't a state we wanna be in forever.
> 
> This patch series audits all callsites that create an UNBOUND workqueue w/
> @max_active==1 and converts them to alloc_ordered_workqueue() as necessary.
> 
> WHAT TO LOOK FOR
> ================
> 
> The conversions are from
> 
>   alloc_workqueue(WQ_UNBOUND | flags, 1, args..)
> 
> to
> 
>   alloc_ordered_workqueue(flags, args...)
> 
> which don't cause any functional changes. If you know that fully ordered
> execution is not ncessary, please let me know. I'll drop the conversion and
> instead add a comment noting the fact to reduce confusion while conversion
> is in progress.
> 
> If you aren't fully sure, it's completely fine to let the conversion
> through. The behavior will stay exactly the same and we can always
> reconsider later.
> 
> As there are follow-up workqueue core changes, I'd really appreciate if the
> patch can be routed through the workqueue tree w/ your acks. Thanks.
> 
> v3: btrfs_alloc_workqueue() excluded again. The concurrency level of a
>     workqueue allocated through btrfs_alloc_workqueue() may be dynamically
>     adjusted through thresh_exec_hook(), so they can't be ordered.
> 
> v2: btrfs_alloc_workqueue() updated too as suggested by Wang.
> 
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Wang Yugui <wangyugui@e16-tech.com>
> Cc: Chris Mason <clm@fb.com>
> Cc: Josef Bacik <josef@toxicpanda.com>
> Cc: David Sterba <dsterba@suse.com>
> Cc: linux-btrfs@vger.kernel.org
> ---
>  fs/btrfs/disk-io.c | 2 +-
>  fs/btrfs/scrub.c   | 6 ++++--
>  2 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> index 59ea049fe7ee..32d08aed88b6 100644
> --- a/fs/btrfs/disk-io.c
> +++ b/fs/btrfs/disk-io.c
> @@ -2217,7 +2217,7 @@ static int btrfs_init_workqueues(struct btrfs_fs_info *fs_info)
>  	fs_info->qgroup_rescan_workers =
>  		btrfs_alloc_workqueue(fs_info, "qgroup-rescan", flags, 1, 0);
>  	fs_info->discard_ctl.discard_workers =
> -		alloc_workqueue("btrfs_discard", WQ_UNBOUND | WQ_FREEZABLE, 1);
> +		alloc_ordered_workqueue("btrfs_discard", WQ_FREEZABLE);
>  
>  	if (!(fs_info->workers && fs_info->hipri_workers &&
>  	      fs_info->delalloc_workers && fs_info->flush_workers &&

I think there are a few more conversions missing. There's a local flags
variable in btrfs_init_workqueues

2175 static int btrfs_init_workqueues(struct btrfs_fs_info *fs_info)
2176 {
2177         u32 max_active = fs_info->thread_pool_size;
2178         unsigned int flags = WQ_MEM_RECLAIM | WQ_FREEZABLE | WQ_UNBOUND;

And used like

2194         fs_info->fixup_workers =
2195                 btrfs_alloc_workqueue(fs_info, "fixup", flags, 1, 0);

2213         fs_info->qgroup_rescan_workers =
2214                 btrfs_alloc_workqueue(fs_info, "qgroup-rescan", flags, 1, 0);

WQ_UNBOUND is not mentioned explicitliy like for the "btrfs_discard"
workqueue.  Patch v2 did the switch in btrfs_alloc_workqueue according
to the max_active/limit_active parameter but this would affect all
queues and not all of them require to be ordered.

In btrfs_resize_thread_pool the workqueue_set_max_active is called
directly or indirectly so this can set the max_active to a user-defined
mount option. Could this be a problem or trigger a warning? This would
lead to max_active==1 + WQ_UNBOUND.

  reply	other threads:[~2023-05-09 14:59 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-09  1:50 [PATCHSET v2 wq/for-6.5-cleanup-ordered] workqueue: Ordered workqueue creation cleanup Tejun Heo
2023-05-09  1:50 ` [PATCH 01/13] scsi: ncr53c8xx: Use default @max_active for hostdata->work_q Tejun Heo
2023-05-21  2:48   ` [PATCH RESEND " Tejun Heo
2023-05-21  6:42     ` Finn Thain
2023-05-22 22:06     ` Martin K. Petersen
2023-05-23  0:58       ` Tejun Heo
2023-05-09  1:50 ` [PATCH 02/13] wifi: mwifiex: Use default @max_active for workqueues Tejun Heo
2023-05-10  8:45   ` Kalle Valo
2023-05-10 18:09   ` Brian Norris
2023-05-10 18:16     ` Tejun Heo
2023-05-10 18:57       ` Brian Norris
2023-05-10 19:19         ` Tejun Heo
2023-05-10 19:50           ` Brian Norris
2023-05-19  0:36   ` Tejun Heo
2023-05-09  1:50 ` [PATCH 03/13] dm integrity: Use alloc_ordered_workqueue() to create ordered workqueues Tejun Heo
2023-05-25 22:10   ` Tejun Heo
2023-05-09  1:50 ` [PATCH 04/13] media: amphion: " Tejun Heo
2023-05-23 12:19   ` Hans Verkuil
2023-05-23 21:25     ` Tejun Heo
2023-05-09  1:50 ` [PATCH 05/13] wifi: ath10/11/12k: " Tejun Heo
2023-05-10  8:41   ` Kalle Valo
2023-05-19  0:41   ` Tejun Heo
2023-05-09  1:50 ` [PATCH 06/13] net: wwan: t7xx: " Tejun Heo
2023-05-25 22:11   ` Tejun Heo
2023-05-09  1:50 ` [PATCH 07/13] soc: qcom: qmi: " Tejun Heo
2023-05-09  1:50 ` [PATCH 08/13] btrfs: " Tejun Heo
2023-05-09 14:53   ` David Sterba [this message]
2023-05-09 15:57     ` Tejun Heo
2023-05-09 23:36       ` David Sterba
2023-05-09 23:47         ` Tejun Heo
2023-05-25 23:33           ` Tejun Heo
2023-05-26 12:52             ` David Sterba
2023-05-09  1:50 ` [PATCH 09/13] net: qrtr: " Tejun Heo
2023-05-25 22:14   ` Tejun Heo
2023-05-09  1:50 ` [PATCH 10/13] rxrpc: " Tejun Heo
2023-05-25 22:14   ` Tejun Heo
2023-05-09  1:50 ` [PATCH 11/13] crypto: octeontx2: " Tejun Heo
2023-05-09  2:18   ` Herbert Xu
2023-05-19  0:42   ` Tejun Heo
2023-05-09  1:50 ` [PATCH 12/13] media: coda: " Tejun Heo
2023-05-09 10:46   ` Philipp Zabel
2023-05-19  0:50   ` Tejun Heo
2023-05-09  1:50 ` [PATCH 13/13] workqueue: Don't implicitly make UNBOUND workqueues w/ @max_active==1 ordered Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230509145332.GA32559@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=jiangshanlai@gmail.com \
    --cc=josef@toxicpanda.com \
    --cc=kernel-team@meta.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=wangyugui@e16-tech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®