From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Tejun Heo <tj@kernel.org>
Cc: jiangshanlai@gmail.com, linux-kernel@vger.kernel.org,
kernel-team@meta.com, Finn Thain <fthain@linux-m68k.org>,
Michael Schmitz <schmitzmic@gmail.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH RESEND 01/13] scsi: ncr53c8xx: Use default @max_active for hostdata->work_q
Date: Mon, 22 May 2023 18:06:56 -0400 [thread overview]
Message-ID: <yq1v8gkm3aq.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <ZGmGZxYmN0En7wAB@slm.duckdns.org> (Tejun Heo's message of "Sat, 20 May 2023 16:48:07 -1000")
Hi Tejun!
> Subject: scsi: ncr53c8xx: Use default @max_active for hostdata->work_q
>
> hostdata->work_q only hosts a single work item, hostdata->main_task, and
> thus doesn't need explicit concurrency limit. Let's use the default
> @max_active. This doesn't cost anything and clearly expresses that
> @max_active doesn't matter.
> It's not a must but it'd be great if I can route this through the workqueue
> tree so that it can go together with other related and followup cleanups.
As Finn pointed out, please make sure it's tagged NCR5380: instead of
ncr53c8xx:. Otherwise OK.
Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2023-05-22 22:08 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-09 1:50 [PATCHSET v2 wq/for-6.5-cleanup-ordered] workqueue: Ordered workqueue creation cleanup Tejun Heo
2023-05-09 1:50 ` [PATCH 01/13] scsi: ncr53c8xx: Use default @max_active for hostdata->work_q Tejun Heo
2023-05-21 2:48 ` [PATCH RESEND " Tejun Heo
2023-05-21 6:42 ` Finn Thain
2023-05-22 22:06 ` Martin K. Petersen [this message]
2023-05-23 0:58 ` Tejun Heo
2023-05-09 1:50 ` [PATCH 02/13] wifi: mwifiex: Use default @max_active for workqueues Tejun Heo
2023-05-10 8:45 ` Kalle Valo
2023-05-10 18:09 ` Brian Norris
2023-05-10 18:16 ` Tejun Heo
2023-05-10 18:57 ` Brian Norris
2023-05-10 19:19 ` Tejun Heo
2023-05-10 19:50 ` Brian Norris
2023-05-19 0:36 ` Tejun Heo
2023-05-09 1:50 ` [PATCH 03/13] dm integrity: Use alloc_ordered_workqueue() to create ordered workqueues Tejun Heo
2023-05-25 22:10 ` Tejun Heo
2023-05-09 1:50 ` [PATCH 04/13] media: amphion: " Tejun Heo
2023-05-23 12:19 ` Hans Verkuil
2023-05-23 21:25 ` Tejun Heo
2023-05-09 1:50 ` [PATCH 05/13] wifi: ath10/11/12k: " Tejun Heo
2023-05-10 8:41 ` Kalle Valo
2023-05-19 0:41 ` Tejun Heo
2023-05-09 1:50 ` [PATCH 06/13] net: wwan: t7xx: " Tejun Heo
2023-05-25 22:11 ` Tejun Heo
2023-05-09 1:50 ` [PATCH 07/13] soc: qcom: qmi: " Tejun Heo
2023-05-09 1:50 ` [PATCH 08/13] btrfs: " Tejun Heo
2023-05-09 14:53 ` David Sterba
2023-05-09 15:57 ` Tejun Heo
2023-05-09 23:36 ` David Sterba
2023-05-09 23:47 ` Tejun Heo
2023-05-25 23:33 ` Tejun Heo
2023-05-26 12:52 ` David Sterba
2023-05-09 1:50 ` [PATCH 09/13] net: qrtr: " Tejun Heo
2023-05-25 22:14 ` Tejun Heo
2023-05-09 1:50 ` [PATCH 10/13] rxrpc: " Tejun Heo
2023-05-25 22:14 ` Tejun Heo
2023-05-09 1:50 ` [PATCH 11/13] crypto: octeontx2: " Tejun Heo
2023-05-09 2:18 ` Herbert Xu
2023-05-19 0:42 ` Tejun Heo
2023-05-09 1:50 ` [PATCH 12/13] media: coda: " Tejun Heo
2023-05-09 10:46 ` Philipp Zabel
2023-05-19 0:50 ` Tejun Heo
2023-05-09 1:50 ` [PATCH 13/13] workqueue: Don't implicitly make UNBOUND workqueues w/ @max_active==1 ordered Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1v8gkm3aq.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=fthain@linux-m68k.org \
--cc=jejb@linux.ibm.com \
--cc=jiangshanlai@gmail.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=schmitzmic@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome