* [PATCH] net: dsa: mv88e6xxx: Fix mv88e6393x EPC write command offset
@ 2023-05-15 22:09 Marco Migliore
2023-05-15 22:37 ` Andrew Lunn
0 siblings, 1 reply; 2+ messages in thread
From: Marco Migliore @ 2023-05-15 22:09 UTC (permalink / raw)
To: andrew
Cc: m.migliore, Florian Fainelli, Vladimir Oltean, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev, linux-kernel
According to datasheet, the command opcode must be specified
into bits [14:12] of the Extended Port Control register (EPC).
Signed-off-by: Marco Migliore <m.migliore@tiesse.com>
---
drivers/net/dsa/mv88e6xxx/port.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/mv88e6xxx/port.h b/drivers/net/dsa/mv88e6xxx/port.h
index aec9d4fd20e3..d19b6303b91f 100644
--- a/drivers/net/dsa/mv88e6xxx/port.h
+++ b/drivers/net/dsa/mv88e6xxx/port.h
@@ -276,7 +276,7 @@
/* Offset 0x10: Extended Port Control Command */
#define MV88E6393X_PORT_EPC_CMD 0x10
#define MV88E6393X_PORT_EPC_CMD_BUSY 0x8000
-#define MV88E6393X_PORT_EPC_CMD_WRITE 0x0300
+#define MV88E6393X_PORT_EPC_CMD_WRITE 0x3000
#define MV88E6393X_PORT_EPC_INDEX_PORT_ETYPE 0x02
/* Offset 0x11: Extended Port Control Data */
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net: dsa: mv88e6xxx: Fix mv88e6393x EPC write command offset
2023-05-15 22:09 [PATCH] net: dsa: mv88e6xxx: Fix mv88e6393x EPC write command offset Marco Migliore
@ 2023-05-15 22:37 ` Andrew Lunn
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Lunn @ 2023-05-15 22:37 UTC (permalink / raw)
To: Marco Migliore
Cc: Florian Fainelli, Vladimir Oltean, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, netdev, linux-kernel
On Tue, May 16, 2023 at 12:09:18AM +0200, Marco Migliore wrote:
> According to datasheet, the command opcode must be specified
> into bits [14:12] of the Extended Port Control register (EPC).
>
> Signed-off-by: Marco Migliore <m.migliore@tiesse.com>
Hi Marco
Please read the netdev FAQ:
https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#netdev-faq
Please add a Fixes: tag, to indicate the patch which introduced the
problem and needs fixing. Also, set the subject to indicate this is
for the net tree.
Thanks
Andrew
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-15 22:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-15 22:09 [PATCH] net: dsa: mv88e6xxx: Fix mv88e6393x EPC write command offset Marco Migliore
2023-05-15 22:37 ` Andrew Lunn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®