* [PATCH] drm/nouveau/acr/ga102: set variable ga102_gsps storage-class-specifier to static
@ 2023-05-17 13:31 Tom Rix
2023-05-22 11:13 ` Karol Herbst
0 siblings, 1 reply; 2+ messages in thread
From: Tom Rix @ 2023-05-17 13:31 UTC (permalink / raw)
To: bskeggs, kherbst, lyude, airlied, daniel, gsamaiya
Cc: dri-devel, nouveau, linux-kernel, Tom Rix
smatch reports
drivers/gpu/drm/nouveau/nvkm/subdev/gsp/ga102.c:49:1: warning: symbol
'ga102_gsps' was not declared. Should it be static?
This variable is only used in its defining file, so it should be static
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/gpu/drm/nouveau/nvkm/subdev/gsp/ga102.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/ga102.c b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/ga102.c
index 525267412c3e..a3996ceca995 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/ga102.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/ga102.c
@@ -45,7 +45,7 @@ ga102_gsp_nofw(struct nvkm_gsp *gsp, int ver, const struct nvkm_gsp_fwif *fwif)
return 0;
}
-struct nvkm_gsp_fwif
+static struct nvkm_gsp_fwif
ga102_gsps[] = {
{ -1, ga102_gsp_nofw, &ga102_gsp },
{}
--
2.27.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] drm/nouveau/acr/ga102: set variable ga102_gsps storage-class-specifier to static
2023-05-17 13:31 [PATCH] drm/nouveau/acr/ga102: set variable ga102_gsps storage-class-specifier to static Tom Rix
@ 2023-05-22 11:13 ` Karol Herbst
0 siblings, 0 replies; 2+ messages in thread
From: Karol Herbst @ 2023-05-22 11:13 UTC (permalink / raw)
To: Tom Rix
Cc: bskeggs, lyude, airlied, daniel, gsamaiya, dri-devel, nouveau,
linux-kernel
Reviewed-by: Karol Herbst <kherbst@redhat.com>
On Wed, May 17, 2023 at 3:31 PM Tom Rix <trix@redhat.com> wrote:
>
> smatch reports
> drivers/gpu/drm/nouveau/nvkm/subdev/gsp/ga102.c:49:1: warning: symbol
> 'ga102_gsps' was not declared. Should it be static?
>
> This variable is only used in its defining file, so it should be static
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/gpu/drm/nouveau/nvkm/subdev/gsp/ga102.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/ga102.c b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/ga102.c
> index 525267412c3e..a3996ceca995 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/ga102.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/ga102.c
> @@ -45,7 +45,7 @@ ga102_gsp_nofw(struct nvkm_gsp *gsp, int ver, const struct nvkm_gsp_fwif *fwif)
> return 0;
> }
>
> -struct nvkm_gsp_fwif
> +static struct nvkm_gsp_fwif
> ga102_gsps[] = {
> { -1, ga102_gsp_nofw, &ga102_gsp },
> {}
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-22 11:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-17 13:31 [PATCH] drm/nouveau/acr/ga102: set variable ga102_gsps storage-class-specifier to static Tom Rix
2023-05-22 11:13 ` Karol Herbst
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®