* [PATCH] drm/mgag200: set variable mgag200_modeset storage-class-specifier to static
@ 2023-05-17 13:41 Tom Rix
2023-05-23 6:44 ` Jocelyn Falempe
2023-06-23 8:28 ` Thomas Zimmermann
0 siblings, 2 replies; 4+ messages in thread
From: Tom Rix @ 2023-05-17 13:41 UTC (permalink / raw)
To: airlied, tzimmermann, airlied, daniel; +Cc: dri-devel, linux-kernel, Tom Rix
smatch reports
drivers/gpu/drm/mgag200/mgag200_drv.c:23:5: warning: symbol
'mgag200_modeset' was not declared. Should it be static?
This variable is only used in its defining file, so it should be static
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/gpu/drm/mgag200/mgag200_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c b/drivers/gpu/drm/mgag200/mgag200_drv.c
index 976f0ab2006b..abddf37f0ea1 100644
--- a/drivers/gpu/drm/mgag200/mgag200_drv.c
+++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
@@ -20,7 +20,7 @@
#include "mgag200_drv.h"
-int mgag200_modeset = -1;
+static int mgag200_modeset = -1;
MODULE_PARM_DESC(modeset, "Disable/Enable modesetting");
module_param_named(modeset, mgag200_modeset, int, 0400);
--
2.27.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/mgag200: set variable mgag200_modeset storage-class-specifier to static
2023-05-17 13:41 [PATCH] drm/mgag200: set variable mgag200_modeset storage-class-specifier to static Tom Rix
@ 2023-05-23 6:44 ` Jocelyn Falempe
2023-06-23 8:28 ` Thomas Zimmermann
1 sibling, 0 replies; 4+ messages in thread
From: Jocelyn Falempe @ 2023-05-23 6:44 UTC (permalink / raw)
To: Tom Rix, airlied, tzimmermann, airlied, daniel; +Cc: linux-kernel, dri-devel
On 17/05/2023 15:41, Tom Rix wrote:
> smatch reports
> drivers/gpu/drm/mgag200/mgag200_drv.c:23:5: warning: symbol
> 'mgag200_modeset' was not declared. Should it be static?
>
> This variable is only used in its defining file, so it should be static
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/gpu/drm/mgag200/mgag200_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c b/drivers/gpu/drm/mgag200/mgag200_drv.c
> index 976f0ab2006b..abddf37f0ea1 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_drv.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
> @@ -20,7 +20,7 @@
>
> #include "mgag200_drv.h"
>
> -int mgag200_modeset = -1;
> +static int mgag200_modeset = -1;
> MODULE_PARM_DESC(modeset, "Disable/Enable modesetting");
> module_param_named(modeset, mgag200_modeset, int, 0400);
>
It looks good to me,
Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>
--
Jocelyn
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/mgag200: set variable mgag200_modeset storage-class-specifier to static
2023-05-17 13:41 [PATCH] drm/mgag200: set variable mgag200_modeset storage-class-specifier to static Tom Rix
2023-05-23 6:44 ` Jocelyn Falempe
@ 2023-06-23 8:28 ` Thomas Zimmermann
2023-06-23 9:05 ` Jocelyn Falempe
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Zimmermann @ 2023-06-23 8:28 UTC (permalink / raw)
To: Tom Rix, airlied, airlied, daniel; +Cc: linux-kernel, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 1201 bytes --]
Am 17.05.23 um 15:41 schrieb Tom Rix:
> smatch reports
> drivers/gpu/drm/mgag200/mgag200_drv.c:23:5: warning: symbol
> 'mgag200_modeset' was not declared. Should it be static?
>
> This variable is only used in its defining file, so it should be static
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/mgag200/mgag200_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c b/drivers/gpu/drm/mgag200/mgag200_drv.c
> index 976f0ab2006b..abddf37f0ea1 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_drv.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
> @@ -20,7 +20,7 @@
>
> #include "mgag200_drv.h"
>
> -int mgag200_modeset = -1;
> +static int mgag200_modeset = -1;
> MODULE_PARM_DESC(modeset, "Disable/Enable modesetting");
> module_param_named(modeset, mgag200_modeset, int, 0400);
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/mgag200: set variable mgag200_modeset storage-class-specifier to static
2023-06-23 8:28 ` Thomas Zimmermann
@ 2023-06-23 9:05 ` Jocelyn Falempe
0 siblings, 0 replies; 4+ messages in thread
From: Jocelyn Falempe @ 2023-06-23 9:05 UTC (permalink / raw)
To: Thomas Zimmermann, Tom Rix, airlied, airlied, daniel
Cc: linux-kernel, dri-devel
On 23/06/2023 10:28, Thomas Zimmermann wrote:
>
>
> Am 17.05.23 um 15:41 schrieb Tom Rix:
>> smatch reports
>> drivers/gpu/drm/mgag200/mgag200_drv.c:23:5: warning: symbol
>> 'mgag200_modeset' was not declared. Should it be static?
>>
>> This variable is only used in its defining file, so it should be static
>>
>> Signed-off-by: Tom Rix <trix@redhat.com>
>
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
>
>> ---
>> drivers/gpu/drm/mgag200/mgag200_drv.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c
>> b/drivers/gpu/drm/mgag200/mgag200_drv.c
>> index 976f0ab2006b..abddf37f0ea1 100644
>> --- a/drivers/gpu/drm/mgag200/mgag200_drv.c
>> +++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
>> @@ -20,7 +20,7 @@
>> #include "mgag200_drv.h"
>> -int mgag200_modeset = -1;
>> +static int mgag200_modeset = -1;
>> MODULE_PARM_DESC(modeset, "Disable/Enable modesetting");
>> module_param_named(modeset, mgag200_modeset, int, 0400);
>
applied to drm-misc-next
Thanks for your contribution.
--
Jocelyn
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-23 9:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-17 13:41 [PATCH] drm/mgag200: set variable mgag200_modeset storage-class-specifier to static Tom Rix
2023-05-23 6:44 ` Jocelyn Falempe
2023-06-23 8:28 ` Thomas Zimmermann
2023-06-23 9:05 ` Jocelyn Falempe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®