[PATCH] wkup_m3_ipc.c: Fix error checking for debugfs_create_dir

[PATCH] wkup_m3_ipc.c: Fix error checking for debugfs_create_dir

[Osama Muhammad]

This patch fixes the error checking in wkup_m3_ipc.c in
debugfs_create_dir. The correct way to check if an error occurred
is 'IS_ERR' inline function.

Signed-off-by: Osama Muhammad <osmtendev@gmail.com>
---
 drivers/soc/ti/wkup_m3_ipc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c
index c9197912ec24..3aff106fc11a 100644
--- a/drivers/soc/ti/wkup_m3_ipc.c
+++ b/drivers/soc/ti/wkup_m3_ipc.c
@@ -202,7 +202,7 @@ static int wkup_m3_ipc_dbg_init(struct wkup_m3_ipc *m3_ipc)
 {
 	m3_ipc->dbg_path = debugfs_create_dir("wkup_m3_ipc", NULL);
 
-	if (!m3_ipc->dbg_path)
+	if (IS_ERR(m3_ipc->dbg_path))
 		return -EINVAL;
 
 	(void)debugfs_create_file("enable_late_halt", 0644,
-- 
2.34.1

Re: [PATCH] wkup_m3_ipc.c: Fix error checking for debugfs_create_dir

[Nishanth Menon]

Hi Osama Muhammad,

On Wed, 17 May 2023 22:24:31 +0500, Osama Muhammad wrote:
> This patch fixes the error checking in wkup_m3_ipc.c in
> debugfs_create_dir. The correct way to check if an error occurred
> is 'IS_ERR' inline function.
> 
> 

I have applied the following to branch ti-next on [1].
Thank you!

[1/1] wkup_m3_ipc.c: Fix error checking for debugfs_create_dir
      commit: b11403c93b7cddc8916b132a395b1524c02447a3

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] git://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D