From: Mark Pearson <mpearson-lenovo@squebb.ca>
To: mpearson-lenovo@squebb.ca
Cc: hdegoede@redhat.com, markgross@kernel.org,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/4] platform/x86: think-lmi: Correct System password interface
Date: Wed, 17 May 2023 14:19:43 -0400 [thread overview]
Message-ID: <20230517181945.3725-2-mpearson-lenovo@squebb.ca> (raw)
In-Reply-To: <20230517181945.3725-1-mpearson-lenovo@squebb.ca>
The system password identification was incorrect. This means that if
the password was enabled it wouldn't be detected correctly; and setting
it would not work.
Correct these mistakes.
Signed-off-by: Mark Pearson <mpearson-lenovo@squebb.ca>
---
drivers/platform/x86/think-lmi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/think-lmi.c b/drivers/platform/x86/think-lmi.c
index d9341305eba9..b8431d3b137f 100644
--- a/drivers/platform/x86/think-lmi.c
+++ b/drivers/platform/x86/think-lmi.c
@@ -171,7 +171,7 @@ MODULE_PARM_DESC(debug_support, "Enable debug command support");
#define TLMI_POP_PWD (1 << 0)
#define TLMI_PAP_PWD (1 << 1)
#define TLMI_HDD_PWD (1 << 2)
-#define TLMI_SYS_PWD (1 << 3)
+#define TLMI_SYS_PWD (1 << 6)
#define TLMI_CERT (1 << 7)
#define to_tlmi_pwd_setting(kobj) container_of(kobj, struct tlmi_pwd_setting, kobj)
@@ -1504,7 +1504,7 @@ static int tlmi_analyze(void)
tlmi_priv.pwd_power->valid = true;
if (tlmi_priv.opcode_support) {
- tlmi_priv.pwd_system = tlmi_create_auth("sys", "system");
+ tlmi_priv.pwd_system = tlmi_create_auth("smp", "system");
if (!tlmi_priv.pwd_system)
goto fail_clear_attr;
--
2.40.1
next prev parent reply other threads:[~2023-05-17 18:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 18:19 [PATCH 1/4] platform/x86: think-lmi: Enable opcode support on BIOS settings Mark Pearson
2023-05-17 18:19 ` Mark Pearson [this message]
2023-05-23 10:46 ` [PATCH 2/4] platform/x86: think-lmi: Correct System password interface Hans de Goede
2023-05-23 12:43 ` Mark Pearson
2023-05-23 13:27 ` Hans de Goede
2023-05-23 16:19 ` Mark Pearson
2023-05-17 18:19 ` [PATCH 3/4] platform/x86: think-lmi: Correct NVME password handling Mark Pearson
2023-05-17 18:19 ` [PATCH 4/4] platform/x86: think-lmi: Don't display unnecessary authentication settings Mark Pearson
2023-05-23 10:46 ` [PATCH 1/4] platform/x86: think-lmi: Enable opcode support on BIOS settings Hans de Goede
2023-05-23 12:36 ` Mark Pearson
2023-05-24 18:20 ` Mark Pearson
2023-05-25 9:52 ` Hans de Goede
2023-05-25 13:54 ` Mark Pearson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230517181945.3725-2-mpearson-lenovo@squebb.ca \
--to=mpearson-lenovo@squebb.ca \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®