From: Mark Pearson <mpearson-lenovo@squebb.ca>
To: mpearson-lenovo@squebb.ca
Cc: hdegoede@redhat.com, markgross@kernel.org,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 4/4] platform/x86: think-lmi: Don't display unnecessary authentication settings
Date: Wed, 17 May 2023 14:19:45 -0400 [thread overview]
Message-ID: <20230517181945.3725-4-mpearson-lenovo@squebb.ca> (raw)
In-Reply-To: <20230517181945.3725-1-mpearson-lenovo@squebb.ca>
If Opcode support is available (which is the standard for all platforms
going forward) then there is no need to have the encoding and kbdlang
attributes visible
Signed-off-by: Mark Pearson <mpearson-lenovo@squebb.ca>
---
drivers/platform/x86/think-lmi.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/platform/x86/think-lmi.c b/drivers/platform/x86/think-lmi.c
index 2d95b1a199fa..46500707f939 100644
--- a/drivers/platform/x86/think-lmi.c
+++ b/drivers/platform/x86/think-lmi.c
@@ -879,6 +879,12 @@ static umode_t auth_attr_is_visible(struct kobject *kobj,
return 0;
}
+ /* Don't display un-needed settings if opcode available */
+ if ((attr == &auth_encoding.attr ||
+ attr == &auth_kbdlang.attr) &&
+ tlmi_priv.opcode_support)
+ return 0;
+
return attr->mode;
}
--
2.40.1
next prev parent reply other threads:[~2023-05-17 18:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 18:19 [PATCH 1/4] platform/x86: think-lmi: Enable opcode support on BIOS settings Mark Pearson
2023-05-17 18:19 ` [PATCH 2/4] platform/x86: think-lmi: Correct System password interface Mark Pearson
2023-05-23 10:46 ` Hans de Goede
2023-05-23 12:43 ` Mark Pearson
2023-05-23 13:27 ` Hans de Goede
2023-05-23 16:19 ` Mark Pearson
2023-05-17 18:19 ` [PATCH 3/4] platform/x86: think-lmi: Correct NVME password handling Mark Pearson
2023-05-17 18:19 ` Mark Pearson [this message]
2023-05-23 10:46 ` [PATCH 1/4] platform/x86: think-lmi: Enable opcode support on BIOS settings Hans de Goede
2023-05-23 12:36 ` Mark Pearson
2023-05-24 18:20 ` Mark Pearson
2023-05-25 9:52 ` Hans de Goede
2023-05-25 13:54 ` Mark Pearson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230517181945.3725-4-mpearson-lenovo@squebb.ca \
--to=mpearson-lenovo@squebb.ca \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®