* [PATCH] Bluetooth: hci_mrvl: use correct __le16 type
@ 2023-05-19 21:44 Min-Hua Chen
0 siblings, 0 replies; only message in thread
From: Min-Hua Chen @ 2023-05-19 21:44 UTC (permalink / raw)
To: Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz
Cc: Min-Hua Chen, linux-bluetooth, linux-kernel
Cast 0xffff to __le16 before comparing it with a __le16 type pkt
and fix the following sparse warnings:
drivers/bluetooth/hci_mrvl.c:170:23: sparse: warning:
restricted __le16 degrades to integer
drivers/bluetooth/hci_mrvl.c:203:23: sparse: warning:
restricted __le16 degrades to integer
Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com>
---
drivers/bluetooth/hci_mrvl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/bluetooth/hci_mrvl.c b/drivers/bluetooth/hci_mrvl.c
index e08222395772..91f63d2b0c02 100644
--- a/drivers/bluetooth/hci_mrvl.c
+++ b/drivers/bluetooth/hci_mrvl.c
@@ -167,7 +167,7 @@ static int mrvl_recv_fw_req(struct hci_dev *hdev, struct sk_buff *skb)
struct mrvl_data *mrvl = hu->priv;
int ret = 0;
- if ((pkt->lhs ^ pkt->rhs) != 0xffff) {
+ if ((pkt->lhs ^ pkt->rhs) != cpu_to_le16(0xffff)) {
bt_dev_err(hdev, "Corrupted mrvl header");
mrvl_send_ack(hu, MRVL_NAK);
ret = -EINVAL;
@@ -200,7 +200,7 @@ static int mrvl_recv_chip_ver(struct hci_dev *hdev, struct sk_buff *skb)
u16 version = le16_to_cpu(pkt->lhs);
int ret = 0;
- if ((pkt->lhs ^ pkt->rhs) != 0xffff) {
+ if ((pkt->lhs ^ pkt->rhs) != cpu_to_le16(0xffff)) {
bt_dev_err(hdev, "Corrupted mrvl header");
mrvl_send_ack(hu, MRVL_NAK);
ret = -EINVAL;
--
2.34.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-05-19 21:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-19 21:44 [PATCH] Bluetooth: hci_mrvl: use correct __le16 type Min-Hua Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®