mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] apei/ghes: correctly return NULL for ghes_get_devices()
@ 2023-05-19 20:03 Li Yang
  2023-05-20  3:09 ` kernel test robot
  0 siblings, 1 reply; 2+ messages in thread
From: Li Yang @ 2023-05-19 20:03 UTC (permalink / raw)
  To: Rafael J. Wysocki, Len Brown, James Morse, Tony Luck,
	Borislav Petkov, Jia He
  Cc: Li Yang, linux-acpi, linux-kernel

Since 315bada690e0 ("EDAC: Check for GHES preference in the
chipset-specific EDAC drivers"), vendor specific EDAC driver will not
probe correctly when CONFIG_ACPI_APEI_GHES is enabled but no GHES device
is present.  Make ghes_get_devices() return NULL when the GHES device
list is empty to fix the problem.

Fixes: 9057a3f7ac36 ("EDAC/ghes: Prepare to make ghes_edac a proper module")
Signed-off-by: Li Yang <leoyang.li@nxp.com>
Cc: Jia He <justin.he@arm.com>
---
 drivers/acpi/apei/ghes.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
index 34ad071a64e9..da1a712f370b 100644
--- a/drivers/acpi/apei/ghes.c
+++ b/drivers/acpi/apei/ghes.c
@@ -1544,9 +1544,11 @@ struct list_head *ghes_get_devices(void)
 
 			pr_warn_once("Force-loading ghes_edac on an unsupported platform. You're on your own!\n");
 		}
+	} else if (list_empty(&ghes_devs)) {
+		return NULL;
+	} else {
+		return &ghes_devs;
 	}
-
-	return &ghes_devs;
 }
 EXPORT_SYMBOL_GPL(ghes_get_devices);
 
-- 
2.38.0


^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-20  3:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-19 20:03 [PATCH] apei/ghes: correctly return NULL for ghes_get_devices() Li Yang
2023-05-20  3:09 ` kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®