* [PATCH] vhost: use kzalloc() instead of kmalloc() followed by memset()
@ 2023-05-22 8:50 Prathu Baronia
2023-05-23 14:54 ` Stefano Garzarella
0 siblings, 1 reply; 2+ messages in thread
From: Prathu Baronia @ 2023-05-22 8:50 UTC (permalink / raw)
To: Michael S. Tsirkin, Jason Wang, kvm, virtualization, netdev,
linux-kernel
Cc: Prathu Baronia
Use kzalloc() to allocate new zeroed out msg node instead of
memsetting a node allocated with kmalloc().
Signed-off-by: Prathu Baronia <prathubaronia2011@gmail.com>
---
drivers/vhost/vhost.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index a92af08e7864..579ecb4ee4d2 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -2575,12 +2575,11 @@ EXPORT_SYMBOL_GPL(vhost_disable_notify);
/* Create a new message. */
struct vhost_msg_node *vhost_new_msg(struct vhost_virtqueue *vq, int type)
{
- struct vhost_msg_node *node = kmalloc(sizeof *node, GFP_KERNEL);
+ /* Make sure all padding within the structure is initialized. */
+ struct vhost_msg_node *node = kzalloc(sizeof(*node), GFP_KERNEL);
if (!node)
return NULL;
- /* Make sure all padding within the structure is initialized. */
- memset(&node->msg, 0, sizeof node->msg);
node->vq = vq;
node->msg.type = type;
return node;
base-commit: 4d6d4c7f541d7027beed4fb86eb2c451bd8d6fff
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] vhost: use kzalloc() instead of kmalloc() followed by memset()
2023-05-22 8:50 [PATCH] vhost: use kzalloc() instead of kmalloc() followed by memset() Prathu Baronia
@ 2023-05-23 14:54 ` Stefano Garzarella
0 siblings, 0 replies; 2+ messages in thread
From: Stefano Garzarella @ 2023-05-23 14:54 UTC (permalink / raw)
To: Prathu Baronia
Cc: Michael S. Tsirkin, Jason Wang, kvm, virtualization, netdev,
linux-kernel
On Mon, May 22, 2023 at 02:20:19PM +0530, Prathu Baronia wrote:
>Use kzalloc() to allocate new zeroed out msg node instead of
>memsetting a node allocated with kmalloc().
>
>Signed-off-by: Prathu Baronia <prathubaronia2011@gmail.com>
>---
> drivers/vhost/vhost.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
>index a92af08e7864..579ecb4ee4d2 100644
>--- a/drivers/vhost/vhost.c
>+++ b/drivers/vhost/vhost.c
>@@ -2575,12 +2575,11 @@ EXPORT_SYMBOL_GPL(vhost_disable_notify);
> /* Create a new message. */
> struct vhost_msg_node *vhost_new_msg(struct vhost_virtqueue *vq, int type)
> {
>- struct vhost_msg_node *node = kmalloc(sizeof *node, GFP_KERNEL);
>+ /* Make sure all padding within the structure is initialized. */
>+ struct vhost_msg_node *node = kzalloc(sizeof(*node), GFP_KERNEL);
> if (!node)
> return NULL;
>
>- /* Make sure all padding within the structure is initialized. */
>- memset(&node->msg, 0, sizeof node->msg);
the patch LGTM:
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
> node->vq = vq;
> node->msg.type = type;
> return node;
>
>base-commit: 4d6d4c7f541d7027beed4fb86eb2c451bd8d6fff
>--
>2.34.1
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-23 14:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-22 8:50 [PATCH] vhost: use kzalloc() instead of kmalloc() followed by memset() Prathu Baronia
2023-05-23 14:54 ` Stefano Garzarella
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®