From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Mike Galbraith <efault@gmx.de>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
lkml <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: r8169: disable ASPM during NAPI poll locking changes --> BUG: Invalid wait context --> PREEMPT_RT pain
Date: Mon, 22 May 2023 15:43:15 +0200 [thread overview]
Message-ID: <20230522134315.oBK0Ll7f@linutronix.de> (raw)
In-Reply-To: <d7fa9ffe0e6cd546b8ff3826379c2cf78e5342b6.camel@gmx.de>
On 2023-05-22 12:41:21 [+0200], Mike Galbraith wrote:
> > I've been looking at the r8169 the other day and it seemed all good
> > since it was only scheduling workqueues and NAPI. But now I see this
> > mac_ocp_lock + config25_lock which are acquire in hardirq context but
> > can't. This needs to be taken care.
>
> I did a patch converting the locks, but didn't post it hoping maybe
> those locks weren't really really needed. It doesn't matter for my
> box, as it doesn't do anything but give RT chances to trip over bugs.
I missed that part. Do you still see those 160us if you keep the locks
as-it as drop the no-threads flag? I'm trying to figure out if this is
due to hwirq context or just blocked PCI-bus due ASPM.
> -Mike
Sebastian
next prev parent reply other threads:[~2023-05-22 13:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-21 6:03 Mike Galbraith
2023-05-21 14:27 ` Mike Galbraith
2023-05-22 8:06 ` Sebastian Andrzej Siewior
2023-05-22 10:32 ` Heiner Kallweit
2023-05-22 10:34 ` Sebastian Andrzej Siewior
2023-05-22 10:41 ` Mike Galbraith
2023-05-22 13:43 ` Sebastian Andrzej Siewior [this message]
2023-05-22 17:02 ` Mike Galbraith
2023-05-22 17:12 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230522134315.oBK0Ll7f@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=efault@gmx.de \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®