mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* Re: [PATCH] sched: deadline: Remove unnecessary ‘NULL’ values from dl_task_offline_migration
  2023-05-23 23:41 [PATCH] sched: deadline: Remove unnecessary ‘NULL’ values from dl_task_offline_migration Li zeming
@ 2023-05-22  7:17 ` Mukesh Ojha
  0 siblings, 0 replies; 2+ messages in thread
From: Mukesh Ojha @ 2023-05-22  7:17 UTC (permalink / raw)
  To: Li zeming, mingo, peterz, juri.lelli, vincent.guittot,
	dietmar.eggemann, rostedt, bsegall, mgorman, bristot, vschneid
  Cc: linux-kernel



On 5/24/2023 5:11 AM, Li zeming wrote:
> later_rq is assigned first, so it does not need to initialize the
> assignment.
> 
> Signed-off-by: Li zeming <zeming@nfschina.com>
> ---
>   kernel/sched/deadline.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index 5a9a4b81c972..d823e608c7f0 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -667,7 +667,7 @@ static struct rq *find_lock_later_rq(struct task_struct *task, struct rq *rq);
>   
>   static struct rq *dl_task_offline_migration(struct rq *rq, struct task_struct *p)
>   {
> -	struct rq *later_rq = NULL;
> +	struct rq *later_rq;
>   	struct dl_bw *dl_b;
>   
>   	later_rq = find_lock_later_rq(p, rq);

Acked-by: Mukesh Ojha <quic_mojha@quicinc.com>

-- Mukesh

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH] sched: deadline: Remove unnecessary ‘NULL’ values from dl_task_offline_migration
@ 2023-05-23 23:41 Li zeming
  2023-05-22  7:17 ` Mukesh Ojha
  0 siblings, 1 reply; 2+ messages in thread
From: Li zeming @ 2023-05-23 23:41 UTC (permalink / raw)
  To: mingo, peterz, juri.lelli, vincent.guittot, dietmar.eggemann,
	rostedt, bsegall, mgorman, bristot, vschneid
  Cc: linux-kernel, Li zeming

later_rq is assigned first, so it does not need to initialize the
assignment.

Signed-off-by: Li zeming <zeming@nfschina.com>
---
 kernel/sched/deadline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 5a9a4b81c972..d823e608c7f0 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -667,7 +667,7 @@ static struct rq *find_lock_later_rq(struct task_struct *task, struct rq *rq);
 
 static struct rq *dl_task_offline_migration(struct rq *rq, struct task_struct *p)
 {
-	struct rq *later_rq = NULL;
+	struct rq *later_rq;
 	struct dl_bw *dl_b;
 
 	later_rq = find_lock_later_rq(p, rq);
-- 
2.18.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-05-22  7:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-23 23:41 [PATCH] sched: deadline: Remove unnecessary ‘NULL’ values from dl_task_offline_migration Li zeming
2023-05-22  7:17 ` Mukesh Ojha

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®