From: Christian Brauner <brauner@kernel.org>
To: Ziqi Zhao <astrajoan@yahoo.com>
Cc: skhan@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [Linux-kernel-mentorship] [PATCH] selftest: pidfd: Omit long and repeating outputs
Date: Wed, 24 May 2023 11:12:01 +0200 [thread overview]
Message-ID: <20230524-tausend-erlitt-b3163dd1dd05@brauner> (raw)
In-Reply-To: <20230523232207.363136-1-astrajoan@yahoo.com>
On Tue, May 23, 2023 at 11:22:07PM +0000, Ziqi Zhao wrote:
> An output message:
>
> > # # waitpid WEXITSTATUS=0
>
> will be printed for 30,000+ times in the `pidfd_test` selftest, which
> does not seem ideal. This patch removes the print logic in the
> `wait_for_pid` function, so each call to this function does not output
> a line by default. Any existing call sites where the extra line might
> be beneficial have been modified to include extra print statements
> outside of the function calls.
>
> Signed-off-by: Ziqi Zhao <astrajoan@yahoo.com>
> ---
Fine by me,
Reviewed-by: Christian Brauner <brauner@kernel.org>
next parent reply other threads:[~2023-05-24 9:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230523232207.363136-1-astrajoan.ref@yahoo.com>
[not found] ` <20230523232207.363136-1-astrajoan@yahoo.com>
2023-05-24 9:12 ` Christian Brauner [this message]
2023-06-05 19:26 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230524-tausend-erlitt-b3163dd1dd05@brauner \
--to=brauner@kernel.org \
--cc=astrajoan@yahoo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®