mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Christian Brauner <brauner@kernel.org>, Ziqi Zhao <astrajoan@yahoo.com>
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [Linux-kernel-mentorship] [PATCH] selftest: pidfd: Omit long and repeating outputs
Date: Mon, 5 Jun 2023 13:26:49 -0600	[thread overview]
Message-ID: <33481784-f1c8-cc0f-4c68-404efcf2258d@linuxfoundation.org> (raw)
In-Reply-To: <20230524-tausend-erlitt-b3163dd1dd05@brauner>

On 5/24/23 03:12, Christian Brauner wrote:
> On Tue, May 23, 2023 at 11:22:07PM +0000, Ziqi Zhao wrote:
>> An output message:
>>
>>> # # waitpid WEXITSTATUS=0
>>
>> will be printed for 30,000+ times in the `pidfd_test` selftest, which
>> does not seem ideal. This patch removes the print logic in the
>> `wait_for_pid` function, so each call to this function does not output
>> a line by default. Any existing call sites where the extra line might
>> be beneficial have been modified to include extra print statements
>> outside of the function calls.
>>
>> Signed-off-by: Ziqi Zhao <astrajoan@yahoo.com>
>> ---
> 
> Fine by me,
> Reviewed-by: Christian Brauner <brauner@kernel.org>

Thank you. Applied to linux-kselftest next for Linux 6.5-rc1.

thanks,
-- Shuah

      reply	other threads:[~2023-06-05 19:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230523232207.363136-1-astrajoan.ref@yahoo.com>
     [not found] ` <20230523232207.363136-1-astrajoan@yahoo.com>
2023-05-24  9:12   ` Christian Brauner
2023-06-05 19:26     ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=33481784-f1c8-cc0f-4c68-404efcf2258d@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=astrajoan@yahoo.com \
    --cc=brauner@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®