* [PATCH] dirvers/gpio: remove redundant reset gpio suffix
@ 2023-05-30 16:32 Lizhe
2023-05-31 9:08 ` Charles Keepax
0 siblings, 1 reply; 2+ messages in thread
From: Lizhe @ 2023-05-30 16:32 UTC (permalink / raw)
To: james.schulman, david.rhodes, tanureal, rf, lgirdwood, broonie,
perex, tiwai, alsa-devel
Cc: patches, linux-kernel, Lizhe
no need to add the suffix "gpio" or "gpios" after "reset", as they will
be automatically added, see of_find_gpio().
Signed-off-by: Lizhe <sensor1010@163.com>
---
sound/soc/codecs/cs35l34.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/cs35l34.c b/sound/soc/codecs/cs35l34.c
index b3f98023e6a7..cbf0f2f4f9df 100644
--- a/sound/soc/codecs/cs35l34.c
+++ b/sound/soc/codecs/cs35l34.c
@@ -1061,7 +1061,7 @@ static int cs35l34_i2c_probe(struct i2c_client *i2c_client)
dev_err(&i2c_client->dev, "Failed to request IRQ: %d\n", ret);
cs35l34->reset_gpio = devm_gpiod_get_optional(&i2c_client->dev,
- "reset-gpios", GPIOD_OUT_LOW);
+ "reset", GPIOD_OUT_LOW);
if (IS_ERR(cs35l34->reset_gpio)) {
ret = PTR_ERR(cs35l34->reset_gpio);
goto err_regulator;
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] dirvers/gpio: remove redundant reset gpio suffix
2023-05-30 16:32 [PATCH] dirvers/gpio: remove redundant reset gpio suffix Lizhe
@ 2023-05-31 9:08 ` Charles Keepax
0 siblings, 0 replies; 2+ messages in thread
From: Charles Keepax @ 2023-05-31 9:08 UTC (permalink / raw)
To: Lizhe
Cc: james.schulman, david.rhodes, tanureal, rf, lgirdwood, broonie,
perex, tiwai, alsa-devel, patches, linux-kernel
On Wed, May 31, 2023 at 12:32:10AM +0800, Lizhe wrote:
> no need to add the suffix "gpio" or "gpios" after "reset", as they will
> be automatically added, see of_find_gpio().
>
Patch itself looks fine, but the subject line should really be
ASoC: cs35l34: ... rather than gpio.
Thanks,
Charles
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-31 9:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-30 16:32 [PATCH] dirvers/gpio: remove redundant reset gpio suffix Lizhe
2023-05-31 9:08 ` Charles Keepax
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®