From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Sukrut Bellary <sukrut.bellary@linux.com>,
Alex Deucher <alexander.deucher@amd.com>,
Sasha Levin <sashal@kernel.org>,
christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com,
daniel@ffwll.ch, Hawking.Zhang@amd.com, Jack.Gui@amd.com,
Arunpravin.PaneerSelvam@amd.com, Victor.Zhao@amd.com,
le.ma@amd.com, mario.limonciello@amd.com, Likun.Gao@amd.com,
Jiadong.Zhu@amd.com, jesse.zhang@amd.com, candice.li@amd.com,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: [PATCH AUTOSEL 6.1 31/33] drm:amd:amdgpu: Fix missing buffer object unlock in failure path
Date: Wed, 31 May 2023 09:41:57 -0400 [thread overview]
Message-ID: <20230531134159.3383703-31-sashal@kernel.org> (raw)
In-Reply-To: <20230531134159.3383703-1-sashal@kernel.org>
From: Sukrut Bellary <sukrut.bellary@linux.com>
[ Upstream commit 60ecaaf54886b0642d5c4744f7fbf1ff0d6b3e42 ]
smatch warning -
1) drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c:3615 gfx_v9_0_kiq_resume()
warn: inconsistent returns 'ring->mqd_obj->tbo.base.resv'.
2) drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:6901 gfx_v10_0_kiq_resume()
warn: inconsistent returns 'ring->mqd_obj->tbo.base.resv'.
Signed-off-by: Sukrut Bellary <sukrut.bellary@linux.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 4 +++-
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 4 +++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
index 2127aab74a68f..84a36b50ddd87 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
@@ -6969,8 +6969,10 @@ static int gfx_v10_0_kiq_resume(struct amdgpu_device *adev)
return r;
r = amdgpu_bo_kmap(ring->mqd_obj, (void **)&ring->mqd_ptr);
- if (unlikely(r != 0))
+ if (unlikely(r != 0)) {
+ amdgpu_bo_unreserve(ring->mqd_obj);
return r;
+ }
gfx_v10_0_kiq_init_queue(ring);
amdgpu_bo_kunmap(ring->mqd_obj);
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
index 1f3fdf6cb903e..fe371022e5104 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
@@ -3650,8 +3650,10 @@ static int gfx_v9_0_kiq_resume(struct amdgpu_device *adev)
return r;
r = amdgpu_bo_kmap(ring->mqd_obj, (void **)&ring->mqd_ptr);
- if (unlikely(r != 0))
+ if (unlikely(r != 0)) {
+ amdgpu_bo_unreserve(ring->mqd_obj);
return r;
+ }
gfx_v9_0_kiq_init_queue(ring);
amdgpu_bo_kunmap(ring->mqd_obj);
--
2.39.2
next prev parent reply other threads:[~2023-05-31 13:48 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 13:41 [PATCH AUTOSEL 6.1 01/33] power: supply: ab8500: Fix external_power_changed race Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 02/33] power: supply: sc27xx: " Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 03/33] power: supply: bq27xxx: Use mod_delayed_work() instead of cancel() + schedule() Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 04/33] ARM: dts: vexpress: add missing cache properties Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 05/33] tools: gpio: fix debounce_period_us output of lsgpio Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 06/33] selftests: gpio: gpio-sim: Fix BUG: test FAILED due to recent change Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 07/33] power: supply: Ratelimit no data debug output Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 08/33] PCI/DPC: Quirk PIO log size for Intel Ice Lake Root Ports Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 09/33] platform/x86: asus-wmi: Ignore WMI events with codes 0x7B, 0xC0 Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 10/33] regulator: Fix error checking for debugfs_create_dir Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 11/33] irqchip/gic-v3: Disable pseudo NMIs on Mediatek devices w/ firmware issues Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 12/33] irqchip/meson-gpio: Mark OF related data as maybe unused Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 13/33] power: supply: Fix logic checking if system is running from battery Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 14/33] ASoC: lpass: Fix for KASAN use_after_free out of bounds Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 15/33] drm: panel-orientation-quirks: Change Air's quirk to support Air Plus Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 16/33] btrfs: scrub: try harder to mark RAID56 block groups read-only Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 17/33] btrfs: handle memory allocation failure in btrfs_csum_one_bio Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 18/33] ASoC: soc-pcm: test if a BE can be prepared Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 19/33] tls: rx: strp: force mixed decrypted records into copy mode Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 20/33] ASoC: Intel: avs: Account for UID of ACPI device Sasha Levin
2023-06-16 19:32 ` Pavel Machek
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 21/33] ASoC: Intel: avs: Add missing checks on FE startup Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 22/33] parisc: Improve cache flushing for PCXL in arch_sync_dma_for_cpu() Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 23/33] parisc: Flush gatt writes and adjust gatt mask in parisc_agp_mask_memory() Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 24/33] MIPS: unhide PATA_PLATFORM Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 25/33] MIPS: Restore Au1300 support Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 26/33] MIPS: Alchemy: fix dbdma2 Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 27/33] mips: Move initrd_start check after initrd address sanitisation Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 28/33] ASoC: cs35l41: Fix default regmap values for some registers Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 29/33] ASoC: dwc: move DMA init to snd_soc_dai_driver probe() Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 30/33] xen/blkfront: Only check REQ_FUA for writes Sasha Levin
2023-05-31 13:41 ` Sasha Levin [this message]
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 32/33] io_uring: unlock sqd->lock before sq thread release CPU Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 33/33] NVMe: Add MAXIO 1602 to bogus nid list Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230531134159.3383703-31-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=Arunpravin.PaneerSelvam@amd.com \
--cc=Hawking.Zhang@amd.com \
--cc=Jack.Gui@amd.com \
--cc=Jiadong.Zhu@amd.com \
--cc=Likun.Gao@amd.com \
--cc=Victor.Zhao@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=candice.li@amd.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jesse.zhang@amd.com \
--cc=le.ma@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=stable@vger.kernel.org \
--cc=sukrut.bellary@linux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®