mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@denx.de>
To: Sasha Levin <sashal@kernel.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	"Cezary Rojewski" <cezary.rojewski@intel.com>,
	"Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>,
	"Mark Brown" <broonie@kernel.org>,
	lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
	pierre-louis.bossart@linux.intel.com,
	peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com,
	ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com,
	ahplka19@gmail.com, alsa-devel@alsa-project.org
Subject: Re: [PATCH AUTOSEL 6.1 20/33] ASoC: Intel: avs: Account for UID of ACPI device
Date: Fri, 16 Jun 2023 21:32:22 +0200	[thread overview]
Message-ID: <ZIy4xhk+kbe01gio@duo.ucw.cz> (raw)
In-Reply-To: <20230531134159.3383703-20-sashal@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1481 bytes --]

Hi!

> Configurations with multiple codecs attached to the platform are
> supported but only if each from the set is different. Add new field
> representing the 'Unique ID' so that codecs that share Vendor and Part
> IDs can be differentiated and thus enabling support for such
> configurations.

Apparently this is preparation for something, but we should not need
it in AUTOSEL as noone will write the uid here.

Best regards,
								Pavel

> +++ b/include/sound/soc-acpi.h
> @@ -170,6 +170,7 @@ struct snd_soc_acpi_link_adr {
>  /* Descriptor for SST ASoC machine driver */
>  struct snd_soc_acpi_mach {
>  	u8 id[ACPI_ID_LEN];
> +	const char *uid;
>  	const struct snd_soc_acpi_codecs *comp_ids;
>  	const u32 link_mask;
>  	const struct snd_soc_acpi_link_adr *links;
> diff --git a/sound/soc/intel/avs/board_selection.c b/sound/soc/intel/avs/board_selection.c
> index 87f9c18be238d..87353b4b0cd73 100644
> --- a/sound/soc/intel/avs/board_selection.c
> +++ b/sound/soc/intel/avs/board_selection.c
> @@ -394,7 +394,7 @@ static int avs_register_i2s_boards(struct avs_dev *adev)
>  	}
>  
>  	for (mach = boards->machs; mach->id[0]; mach++) {
> -		if (!acpi_dev_present(mach->id, NULL, -1))
> +		if (!acpi_dev_present(mach->id, mach->uid, -1))
>  			continue;
>  
>  		if (mach->machine_quirk)

-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

  reply	other threads:[~2023-06-16 19:32 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-31 13:41 [PATCH AUTOSEL 6.1 01/33] power: supply: ab8500: Fix external_power_changed race Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 02/33] power: supply: sc27xx: " Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 03/33] power: supply: bq27xxx: Use mod_delayed_work() instead of cancel() + schedule() Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 04/33] ARM: dts: vexpress: add missing cache properties Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 05/33] tools: gpio: fix debounce_period_us output of lsgpio Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 06/33] selftests: gpio: gpio-sim: Fix BUG: test FAILED due to recent change Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 07/33] power: supply: Ratelimit no data debug output Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 08/33] PCI/DPC: Quirk PIO log size for Intel Ice Lake Root Ports Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 09/33] platform/x86: asus-wmi: Ignore WMI events with codes 0x7B, 0xC0 Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 10/33] regulator: Fix error checking for debugfs_create_dir Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 11/33] irqchip/gic-v3: Disable pseudo NMIs on Mediatek devices w/ firmware issues Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 12/33] irqchip/meson-gpio: Mark OF related data as maybe unused Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 13/33] power: supply: Fix logic checking if system is running from battery Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 14/33] ASoC: lpass: Fix for KASAN use_after_free out of bounds Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 15/33] drm: panel-orientation-quirks: Change Air's quirk to support Air Plus Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 16/33] btrfs: scrub: try harder to mark RAID56 block groups read-only Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 17/33] btrfs: handle memory allocation failure in btrfs_csum_one_bio Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 18/33] ASoC: soc-pcm: test if a BE can be prepared Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 19/33] tls: rx: strp: force mixed decrypted records into copy mode Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 20/33] ASoC: Intel: avs: Account for UID of ACPI device Sasha Levin
2023-06-16 19:32   ` Pavel Machek [this message]
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 21/33] ASoC: Intel: avs: Add missing checks on FE startup Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 22/33] parisc: Improve cache flushing for PCXL in arch_sync_dma_for_cpu() Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 23/33] parisc: Flush gatt writes and adjust gatt mask in parisc_agp_mask_memory() Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 24/33] MIPS: unhide PATA_PLATFORM Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 25/33] MIPS: Restore Au1300 support Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 26/33] MIPS: Alchemy: fix dbdma2 Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 27/33] mips: Move initrd_start check after initrd address sanitisation Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 28/33] ASoC: cs35l41: Fix default regmap values for some registers Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 29/33] ASoC: dwc: move DMA init to snd_soc_dai_driver probe() Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 30/33] xen/blkfront: Only check REQ_FUA for writes Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 31/33] drm:amd:amdgpu: Fix missing buffer object unlock in failure path Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 32/33] io_uring: unlock sqd->lock before sq thread release CPU Sasha Levin
2023-05-31 13:41 ` [PATCH AUTOSEL 6.1 33/33] NVMe: Add MAXIO 1602 to bogus nid list Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZIy4xhk+kbe01gio@duo.ucw.cz \
    --to=pavel@denx.de \
    --cc=ahplka19@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=amadeuszx.slawinski@linux.intel.com \
    --cc=broonie@kernel.org \
    --cc=cezary.rojewski@intel.com \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=peter.ujfalusi@linux.intel.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=ranjani.sridharan@linux.intel.com \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tiwai@suse.com \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®