mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: "Kumar, Udit" <u-kumar1@ti.com>
Cc: Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Rob Herring <robh+dt@kernel.org>, <linux-kernel@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	Tero Kristo <kristo@kernel.org>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Nitin Yadav <n-yadav@ti.com>, Andrew Davis <afd@ti.com>
Subject: Re: [PATCH 4/7] arm64: dts: ti: k3-j7200-mcu: Add mcu_secproxy
Date: Wed, 31 May 2023 12:39:06 -0500	[thread overview]
Message-ID: <20230531173906.zznrzuxfytk5feun@spied> (raw)
In-Reply-To: <e25936b9-d85c-dfe8-0eb1-07b51fdfff1e@ti.com>

On 22:37-20230531, Kumar, Udit wrote:
[...]
> > +	secure_proxy_mcu: mailbox@2a480000 {
> I think, we should start name as  mailbox@2a380000
> > +		compatible = "ti,am654-secure-proxy";
> > +		#mbox-cells = <1>;
> > +		reg-names = "target_data", "rt", "scfg";
> > +		reg = <0x0 0x2a480000 0x0 0x80000>,
> > +		      <0x0 0x2a380000 0x0 0x80000>,
> > +		      <0x0 0x2a400000 0x0 0x80000>;
> 
> I think, we should have increasing order for reg. Unless there is some
> strong reason to keep in this way.

Binding is defined this way - the items section in the binding
enforces the order. As a result the first reg entry(target_data)
address causes the node name.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

  reply	other threads:[~2023-05-31 17:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-30 16:58 [PATCH 0/7] arm64: dts: ti: Add additional secproxy instances Nishanth Menon
2023-05-30 16:58 ` [PATCH 1/7] arm64: dts: ti: k3-am62-main: Add sa3_secproxy Nishanth Menon
2023-05-30 16:58 ` [PATCH 2/7] arm64: dts: ti: k3-am62a-main: " Nishanth Menon
2023-05-30 16:58 ` [PATCH 3/7] arm64: dts: ti: k3-am65-mcu: Add mcu_secproxy Nishanth Menon
2023-05-30 16:58 ` [PATCH 4/7] arm64: dts: ti: k3-j7200-mcu: " Nishanth Menon
2023-05-31 17:07   ` Kumar, Udit
2023-05-31 17:39     ` Nishanth Menon [this message]
2023-06-06 13:08       ` Kumar, Udit
2023-05-30 16:58 ` [PATCH 5/7] arm64: dts: ti: k3-j721e-mcu: " Nishanth Menon
2023-05-30 16:58 ` [PATCH 6/7] arm64: dts: ti: k3-j721s2-mcu-wakeup: Add sa3_secproxy and mcu_sec_proxy Nishanth Menon
2023-05-30 16:59 ` [PATCH 7/7] arm64: dts: ti: k3-j784s4-mcu-wakeup: " Nishanth Menon
2023-06-15 13:13 ` [PATCH 0/7] arm64: dts: ti: Add additional secproxy instances Vignesh Raghavendra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230531173906.zznrzuxfytk5feun@spied \
    --to=nm@ti.com \
    --cc=afd@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=n-yadav@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=u-kumar1@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®