mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* Fwd: Started to get "memfd_create() without MFD_EXEC nor MFD_NOEXEC_SEAL"
@ 2023-06-01  2:07 Bagas Sanjaya
  2023-06-01  7:18 ` Vlastimil Babka
  0 siblings, 1 reply; 5+ messages in thread
From: Bagas Sanjaya @ 2023-06-01  2:07 UTC (permalink / raw)
  To: Linux Kernel Mailing List, Linux Regressions,
	Linux Memory Management List
  Cc: Jeff Xu, Daniel Verkamp, Kees Cook, David Herrmann,
	Dmitry Torokhov, Hugh Dickins, Jann Horn, Jorge Lucangeli Obes,
	Shuah Khan, Andrew Morton, Stuart Foster

Hi,

I notice a regression report on Bugzilla [1]. Quoting from it:

> Recent kernels seem to generate this:
> 
> "memfd_create() without MFD_EXEC nor MFD_NOEXEC_SEAL, pid=3976 'Xorg'"
> 
> Is this a kernel problem or something to do with Xorg ?
> 
> Seen in Kernels 6.3.4 and 6.4.0-rc4.
> 
> Thanks

See Bugzilla for the full thread and attached logs (dmesg, xorg, bisection
log).

Anyway, I'm adding it to regzbot:

#regzbot introduced: 105ff5339f498a https://bugzilla.kernel.org/show_bug.cgi?id=217508
#regzbot title: memfd_create() without MFD_EXEC nor MFD_NOEXEC_SEAL on Xorg

Thanks.

[1]: https://bugzilla.kernel.org/show_bug.cgi?id=217508

-- 
An old man doll... just what I always wanted! - Clara

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Fwd: Started to get "memfd_create() without MFD_EXEC nor MFD_NOEXEC_SEAL"
  2023-06-01  2:07 Fwd: Started to get "memfd_create() without MFD_EXEC nor MFD_NOEXEC_SEAL" Bagas Sanjaya
@ 2023-06-01  7:18 ` Vlastimil Babka
  2023-06-01 14:12   ` Kees Cook
  0 siblings, 1 reply; 5+ messages in thread
From: Vlastimil Babka @ 2023-06-01  7:18 UTC (permalink / raw)
  To: Bagas Sanjaya, Linux Kernel Mailing List, Linux Regressions,
	Linux Memory Management List
  Cc: Jeff Xu, Daniel Verkamp, Kees Cook, David Herrmann,
	Dmitry Torokhov, Hugh Dickins, Jann Horn, Jorge Lucangeli Obes,
	Shuah Khan, Andrew Morton, Stuart Foster

On 6/1/23 04:07, Bagas Sanjaya wrote:
> Hi,
> 
> I notice a regression report on Bugzilla [1]. Quoting from it:
> 
>> Recent kernels seem to generate this:
>> 
>> "memfd_create() without MFD_EXEC nor MFD_NOEXEC_SEAL, pid=3976 'Xorg'"
>> 
>> Is this a kernel problem or something to do with Xorg ?
>> 
>> Seen in Kernels 6.3.4 and 6.4.0-rc4.
>> 
>> Thanks
> 
> See Bugzilla for the full thread and attached logs (dmesg, xorg, bisection
> log).
> 
> Anyway, I'm adding it to regzbot:
> 
> #regzbot introduced: 105ff5339f498a https://bugzilla.kernel.org/show_bug.cgi?id=217508
> #regzbot title: memfd_create() without MFD_EXEC nor MFD_NOEXEC_SEAL on Xorg

Hm indeed it seems to have introduced 2 new flags and immediately warn if
any process doesn't use them. Maybe it would make sense for some of the
non-default values of vm.memfd_noexec, but it's too early to warn
unconditionally everywhere, no?

> Thanks.
> 
> [1]: https://bugzilla.kernel.org/show_bug.cgi?id=217508
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Fwd: Started to get "memfd_create() without MFD_EXEC nor MFD_NOEXEC_SEAL"
  2023-06-01  7:18 ` Vlastimil Babka
@ 2023-06-01 14:12   ` Kees Cook
  2023-06-02  2:15     ` Bagas Sanjaya
  0 siblings, 1 reply; 5+ messages in thread
From: Kees Cook @ 2023-06-01 14:12 UTC (permalink / raw)
  To: Vlastimil Babka
  Cc: Bagas Sanjaya, Linux Kernel Mailing List, Linux Regressions,
	Linux Memory Management List, Jeff Xu, Daniel Verkamp,
	David Herrmann, Dmitry Torokhov, Hugh Dickins, Jann Horn,
	Jorge Lucangeli Obes, Shuah Khan, Andrew Morton, Stuart Foster

On Thu, Jun 01, 2023 at 09:18:47AM +0200, Vlastimil Babka wrote:
> On 6/1/23 04:07, Bagas Sanjaya wrote:
> > Hi,
> > 
> > I notice a regression report on Bugzilla [1]. Quoting from it:
> > 
> >> Recent kernels seem to generate this:
> >> 
> >> "memfd_create() without MFD_EXEC nor MFD_NOEXEC_SEAL, pid=3976 'Xorg'"
> >> 
> >> Is this a kernel problem or something to do with Xorg ?
> >> 
> >> Seen in Kernels 6.3.4 and 6.4.0-rc4.
> >> 
> >> Thanks
> > 
> > See Bugzilla for the full thread and attached logs (dmesg, xorg, bisection
> > log).
> > 
> > Anyway, I'm adding it to regzbot:
> > 
> > #regzbot introduced: 105ff5339f498a https://bugzilla.kernel.org/show_bug.cgi?id=217508
> > #regzbot title: memfd_create() without MFD_EXEC nor MFD_NOEXEC_SEAL on Xorg
> 
> Hm indeed it seems to have introduced 2 new flags and immediately warn if
> any process doesn't use them. Maybe it would make sense for some of the
> non-default values of vm.memfd_noexec, but it's too early to warn
> unconditionally everywhere, no?

This is pretty standard for getting new options like this noticed by
userspace -- there is no regression in _behavior_. It's just a reminder
to fix userspace code.

-Kees

> > 
> > [1]: https://bugzilla.kernel.org/show_bug.cgi?id=217508
> > 
> 

-- 
Kees Cook

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Fwd: Started to get "memfd_create() without MFD_EXEC nor MFD_NOEXEC_SEAL"
  2023-06-01 14:12   ` Kees Cook
@ 2023-06-02  2:15     ` Bagas Sanjaya
  2023-06-02  7:12       ` Stuart Foster
  0 siblings, 1 reply; 5+ messages in thread
From: Bagas Sanjaya @ 2023-06-02  2:15 UTC (permalink / raw)
  To: Kees Cook, Vlastimil Babka
  Cc: Linux Kernel Mailing List, Linux Regressions,
	Linux Memory Management List, Jeff Xu, Daniel Verkamp,
	David Herrmann, Dmitry Torokhov, Hugh Dickins, Jann Horn,
	Jorge Lucangeli Obes, Shuah Khan, Andrew Morton, Stuart Foster

On 6/1/23 21:12, Kees Cook wrote:
>> Hm indeed it seems to have introduced 2 new flags and immediately warn if
>> any process doesn't use them. Maybe it would make sense for some of the
>> non-default values of vm.memfd_noexec, but it's too early to warn
>> unconditionally everywhere, no?
> 
> This is pretty standard for getting new options like this noticed by
> userspace -- there is no regression in _behavior_. It's just a reminder
> to fix userspace code.
> 

Telling regzbot:

#regzbot invalid: not a kernel regression, but userspace fix is needed

Thanks.

-- 
An old man doll... just what I always wanted! - Clara


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Fwd: Started to get "memfd_create() without MFD_EXEC nor MFD_NOEXEC_SEAL"
  2023-06-02  2:15     ` Bagas Sanjaya
@ 2023-06-02  7:12       ` Stuart Foster
  0 siblings, 0 replies; 5+ messages in thread
From: Stuart Foster @ 2023-06-02  7:12 UTC (permalink / raw)
  To: Bagas Sanjaya, Kees Cook, Vlastimil Babka
  Cc: Linux Kernel Mailing List, Linux Regressions,
	Linux Memory Management List, Jeff Xu, Daniel Verkamp,
	David Herrmann, Dmitry Torokhov, Hugh Dickins, Jann Horn,
	Jorge Lucangeli Obes, Shuah Khan, Andrew Morton

On 02/06/2023 03:15, Bagas Sanjaya wrote:
> On 6/1/23 21:12, Kees Cook wrote:
>>> Hm indeed it seems to have introduced 2 new flags and immediately warn if
>>> any process doesn't use them. Maybe it would make sense for some of the
>>> non-default values of vm.memfd_noexec, but it's too early to warn
>>> unconditionally everywhere, no?
>>
>> This is pretty standard for getting new options like this noticed by
>> userspace -- there is no regression in _behavior_. It's just a reminder
>> to fix userspace code.
>>
> 
> Telling regzbot:
> 
> #regzbot invalid: not a kernel regression, but userspace fix is needed
> 
> Thanks.
> 

Issue raised with XOrg:

https://gitlab.freedesktop.org/xorg/xserver/-/issues/1553


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-06-02  7:14 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-01  2:07 Fwd: Started to get "memfd_create() without MFD_EXEC nor MFD_NOEXEC_SEAL" Bagas Sanjaya
2023-06-01  7:18 ` Vlastimil Babka
2023-06-01 14:12   ` Kees Cook
2023-06-02  2:15     ` Bagas Sanjaya
2023-06-02  7:12       ` Stuart Foster

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®